r87228 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87227‎ | r87228 | r87229 >
Date:22:28, 1 May 2011
Author:platonides
Status:deferred
Tags:
Comment:
Apply r86676+r86709 changes to the native preprocessor.
Modified paths:
  • /trunk/extensions/NativePreprocessor/preprocesstoobj.c (modified) (history)

Diff [purge]

Index: trunk/extensions/NativePreprocessor/preprocesstoobj.c
@@ -356,12 +356,12 @@
357357
358358 if ( parentNode ) {
359359 if ( parentNode->commentEnd != -1 && parentNode->commentEnd == wsStart - 1 ) {
360 - // Comments abutting, no change in visual end
361 - parentNode->commentEnd = wsEnd;
 360+
362361 } else {
363362 parentNode->visualEnd = wsStart - 1;
364 - parentNode->commentEnd = endPos;
365363 }
 364+ // Else comments abutting, no change in visual end
 365+ parentNode->commentEnd = endPos;
366366 }
367367 i = endPos + 1;
368368 addNodeWithText(comment_node, text, startPos, endPos - startPos + 1);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86676Fix bug #28642 - wrong part->commentEnd set to abbutting comments...mah22:20, 21 April 2011
r86709Updated patch from Bergi re: r86676 with tested code to fix bug #28642mah14:25, 22 April 2011

Status & tagging log