r87223 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87222‎ | r87223 | r87224 >
Date:21:49, 1 May 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r87222
Modified paths:
  • /branches/REL1_17/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/REL1_17/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/Installer.php
@@ -624,9 +624,8 @@
625625 $this->setVar( '_CompiledDBs', $compiledDBs );
626626
627627 if ( !$compiledDBs ) {
628 - $this->showError( 'config-no-db' );
 628+ $this->showError( 'config-no-db', $wgLang->commaList( $allNames ) );
629629 // FIXME: this only works for the web installer!
630 - $this->showHelpBox( 'config-no-db-help', $wgLang->commaList( $allNames ) );
631630 return false;
632631 }
633632
Property changes on: branches/REL1_17/phase3/includes/installer/Installer.php
___________________________________________________________________
Modified: svn:mergeinfo
634633 Merged /trunk/phase3/includes/installer/Installer.php:r87222
Index: branches/REL1_17/phase3/includes/installer/Installer.i18n.php
@@ -97,8 +97,7 @@
9898 If you run a high-traffic site, you should read a little on [http://www.mediawiki.org/wiki/Unicode_normalization_considerations Unicode normalization].",
9999 'config-unicode-update-warning' => "'''Warning''': The installed version of the Unicode normalization wrapper uses an older version of [http://site.icu-project.org/ the ICU project's] library.
100100 You should [http://www.mediawiki.org/wiki/Unicode_normalization_considerations upgrade] if you are at all concerned about using Unicode.",
101 - 'config-no-db' => 'Could not find a suitable database driver!',
102 - 'config-no-db-help' => 'You need to install a database driver for PHP.
 101+ 'config-no-db' => 'Could not find a suitable database driver! You need to install a database driver for PHP.
103102 The following database types are supported: $1.
104103
105104 If you are on shared hosting, ask your hosting provider to install a suitable database driver.
Property changes on: branches/REL1_17/phase3/includes/installer/Installer.i18n.php
___________________________________________________________________
Modified: svn:mergeinfo
106105 Merged /trunk/phase3/includes/installer/Installer.i18n.php:r87222

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87222When we failed to detect a DB driver, put the help info in the failure box, r...demon21:48, 1 May 2011

Status & tagging log