r87222 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87221‎ | r87222 | r87223 >
Date:21:48, 1 May 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
When we failed to detect a DB driver, put the help info in the failure box, rather than hiding it in a little help box nobody's going to find
Modified paths:
  • /trunk/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -622,9 +622,8 @@
623623 $this->setVar( '_CompiledDBs', $compiledDBs );
624624
625625 if ( !$compiledDBs ) {
626 - $this->showError( 'config-no-db' );
 626+ $this->showError( 'config-no-db', $wgLang->commaList( $allNames ) );
627627 // FIXME: this only works for the web installer!
628 - $this->showHelpBox( 'config-no-db-help', $wgLang->commaList( $allNames ) );
629628 return false;
630629 }
631630
Index: trunk/phase3/includes/installer/Installer.i18n.php
@@ -97,8 +97,7 @@
9898 If you run a high-traffic site, you should read a little on [http://www.mediawiki.org/wiki/Unicode_normalization_considerations Unicode normalization].",
9999 'config-unicode-update-warning' => "'''Warning''': The installed version of the Unicode normalization wrapper uses an older version of [http://site.icu-project.org/ the ICU project's] library.
100100 You should [http://www.mediawiki.org/wiki/Unicode_normalization_considerations upgrade] if you are at all concerned about using Unicode.",
101 - 'config-no-db' => 'Could not find a suitable database driver!',
102 - 'config-no-db-help' => 'You need to install a database driver for PHP.
 101+ 'config-no-db' => 'Could not find a suitable database driver! You need to install a database driver for PHP.
103102 The following database types are supported: $1.
104103
105104 If you are on shared hosting, ask your hosting provider to install a suitable database driver.

Follow-up revisions

RevisionCommit summaryAuthorDate
r87223MFT r87222demon21:49, 1 May 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   22:16, 7 June 2011

Error message seems to work ok... I did though find that things seem to get a bit confused if you change what drivers are available once you get past the environmental check page; it seems to look up the available DB types once there, and doesn't update them until you go back to the environment check page. :) Most of the time this should be fine.

Status & tagging log