r87201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87200‎ | r87201 | r87202 >
Date:18:24, 1 May 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 26664) Add 'url' to meta=globaluserinfo and/or 'database' to action=sitematrix

Added dbname to SiteMatrix output
Modified paths:
  • /trunk/extensions/SiteMatrix/SiteMatrixApi.php (modified) (history)
  • /trunk/extensions/SiteMatrix/SiteMatrix_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SiteMatrix/SiteMatrixApi.php
@@ -48,7 +48,7 @@
4949 'name' => $langNames[$lang],
5050 'site' => array(),
5151 );
52 - if( isset( $localLanguageNames[$lang] ) ) {
 52+ if ( isset( $localLanguageNames[$lang] ) ) {
5353 $language['localname'] = $localLanguageNames[$lang];
5454 }
5555
@@ -63,9 +63,10 @@
6464 $url = $matrix->getUrl( $lang, $site );
6565 $site_out = array(
6666 'url' => $url,
 67+ 'dbname' => $matrix->getDBName( $lang, $site ),
6768 'code' => $site,
6869 );
69 - if( $matrix->isClosed( $lang, $site ) ) {
 70+ if ( $matrix->isClosed( $lang, $site ) ) {
7071 $site_out['closed'] = '';
7172 if ( $closed ) {
7273 $skip = false;
@@ -96,6 +97,7 @@
9798
9899 $wiki = array();
99100 $wiki['url'] = $url;
 101+ $wiki['dbname'] = $matrix->getDBName( $lang, $site );
100102 $wiki['code'] = str_replace( '_', '-', $lang ) . ( $site != 'wiki' ? $site : '' );
101103
102104 $skip = true;
Index: trunk/extensions/SiteMatrix/SiteMatrix_body.php
@@ -133,13 +133,22 @@
134134 */
135135 public function getUrl( $minor, $major ){
136136 global $wgConf;
137 - $dbname = $minor . $major;
 137+ $dbname = $this->getDBName( $minor, $major );
138138 $minor = str_replace( '_', '-', $minor );
139139 return $wgConf->get( 'wgServer', $dbname, $major,
140140 array( 'lang' => $minor, 'site' => $major ) );
141141 }
142142
143143 /**
 144+ * @param $minor string
 145+ * @param $major string
 146+ * @return string
 147+ */
 148+ public function getDBName( $minor, $major ) {
 149+ return $minor . $major;
 150+ }
 151+
 152+ /**
144153 * @param string $minor Language
145154 * @param string $major Site
146155 * @return bool
@@ -156,7 +165,7 @@
157166 public function isClosed( $minor, $major ) {
158167 global $wgSiteMatrixClosedSites;
159168
160 - $dbname = $minor . $major;
 169+ $dbname = $this->getDBName( $minor, $major );
161170
162171 if ( $wgSiteMatrixClosedSites === null ) {
163172 // Fallback to old behavior checking read-only settings;

Follow-up revisions

RevisionCommit summaryAuthorDate
r87206* (bug 26664) Add 'url' to meta=globaluserinfo and/or 'database' to action=si...reedy18:56, 1 May 2011

Status & tagging log