r87136 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87135‎ | r87136 | r87137 >
Date:21:41, 29 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
rem dead globals
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_QueryPrinters.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php
@@ -111,7 +111,7 @@
112112 $fatalError = $validator->hasFatalError();
113113
114114 if ( $fatalError === false ) {
115 - global $wgParser, $wgTitle;
 115+ global $wgParser;
116116
117117 $params = $validator->getParameterValues();
118118 $mapName = $this->service->getMapId();
Index: trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInputs.php
@@ -36,7 +36,7 @@
3737 final class SMFormInputs {
3838
3939 public static function initialize() {
40 - global $smgDir, $wgAutoloadClasses, $sfgFormPrinter;
 40+ global $wgAutoloadClasses;
4141
4242 // This code should not get called when SF is not loaded, but let's have this
4343 // check to not run into problems when people mess up the settings.
@@ -80,7 +80,7 @@
8181 * @param strig $mainName
8282 */
8383 private static function initFormHook( $inputName, $mainName = '' ) {
84 - global $wgAutoloadClasses, $sfgFormPrinter, $smgDir;
 84+ global $sfgFormPrinter;
8585
8686 // Add the form input hook for the service.
8787 $field_args = array();
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_QueryPrinters.php
@@ -21,7 +21,7 @@
2222 * Initialization function for Maps query printer functionality.
2323 */
2424 public static function initialize() {
25 - global $smgDir, $wgAutoloadClasses;
 25+ global $wgAutoloadClasses;
2626
2727 $wgAutoloadClasses['SMQueryHandler'] = dirname( __FILE__ ) . '/SM_QueryHandler.php';
2828 $wgAutoloadClasses['SMMapper'] = dirname( __FILE__ ) . '/SM_Mapper.php';
@@ -65,7 +65,7 @@
6666 * @param array $aliases
6767 */
6868 private static function initFormat( $format, $formatClass, array $aliases = array() ) {
69 - global $wgAutoloadClasses, $smgDir, $smwgResultAliases;
 69+ global $smwgResultAliases;
7070
7171 // Add the QP to SMW.
7272 self::addFormatQP( $format, $formatClass );

Status & tagging log