r87123 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87122‎ | r87123 | r87124 >
Date:14:48, 29 April 2011
Author:raymond
Status:ok
Tags:
Comment:
Show navigation bar as subtitle as all other navbars too for consistency
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.class.php (modified) (history)
  • /trunk/extensions/AbuseFilter/abusefilter.css (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.class.php
@@ -143,6 +143,9 @@
144144 $links = array();
145145
146146 foreach ( $linkDefs as $name => $page ) {
 147+ // Give grep a chance to find the usages:
 148+ // abusefilter-topnav-home, abusefilter-topnav-test, abusefilter-topnav-examine
 149+ // abusefilter-topnav-log, abusefilter-topnav-tools, abusefilter-topnav-import
147150 $msgName = "abusefilter-topnav-$name";
148151
149152 if ( isset( $msgOverrides[$name] ) ) {
@@ -159,12 +162,12 @@
160163 }
161164 }
162165
163 - $linkStr = '(' . $wgLang->pipeList( $links ) . ')';
 166+ $linkStr = wfMsg( 'parentheses', $wgLang->pipeList( $links ) );
164167 $linkStr = wfMsgExt( 'abusefilter-topnav', 'parseinline' ) . " $linkStr";
165168
166169 $linkStr = Xml::tags( 'div', array( 'class' => 'mw-abusefilter-navigation' ), $linkStr );
167170
168 - $out->addHTML( $linkStr );
 171+ $out->setSubtitle( $linkStr );
169172 }
170173
171174 /**
Index: trunk/extensions/AbuseFilter/abusefilter.css
@@ -69,10 +69,6 @@
7070 padding-left: 25px;
7171 }
7272
73 -.mw-abusefilter-navigation {
74 - text-align: center;
75 -}
76 -
7773 table.mw-abusefilter-diff {
7874 width: 80%;
7975 border-collapse: collapse;

Status & tagging log