r87101 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87100‎ | r87101 | r87102 >
Date:21:34, 28 April 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Moved the tab break from the link to the span. This allows for multiple icons, as icons overwrite this link image and thus wouldn't have a tab break. This was originally solved for the watchlist star by using a right margin, so this one is removed to prevent double borders.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
@@ -165,10 +165,6 @@
166166 height: 1.9em;
167167 padding-left: 0.5em;
168168 padding-right: 0.5em;
169 - /* @embed */
170 - background-image: url(images/tab-break.png);
171 - background-position: bottom right;
172 - background-repeat: no-repeat;
173169 color: #0645ad;
174170 cursor: pointer;
175171 font-size: 0.8em;
@@ -177,6 +173,10 @@
178174 div.vectorTabs li > a {
179175 display: block;
180176 }
 177+ div.vectorTabs li.icon a {
 178+ background-position: bottom right;
 179+ background-repeat: no-repeat;
 180+ }
181181 /* OVERRIDDEN BY COMPLIANT BROWSERS */
182182 div.vectorTabs span a {
183183 display: inline-block;
@@ -188,6 +188,13 @@
189189 float: left;
190190 display: block;
191191 }
 192+ div.vectorTabs span {
 193+ display: inline-block;
 194+ /* @embed */
 195+ background-image: url(images/tab-break.png);
 196+ background-position: bottom right;
 197+ background-repeat: no-repeat;
 198+ }
192199 div.vectorTabs li.selected a,
193200 div.vectorTabs li.selected a:visited{
194201 color: #333333;
@@ -1166,10 +1173,6 @@
11671174 }
11681175
11691176 /* Watch/Unwatch Icon Styling */
1170 -#ca-unwatch.icon,
1171 -#ca-watch.icon {
1172 - margin-right:1px;
1173 -}
11741177 #ca-unwatch.icon a,
11751178 #ca-watch.icon a {
11761179 margin: 0;

Status & tagging log