r87072 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87071‎ | r87072 | r87073 >
Date:13:44, 28 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added some docs
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Blob.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Bool.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Concept.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Error.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Number.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Property.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_String.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Time.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_URI.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_WikiPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DataItem.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_QueryResult.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_QueryResult.php
@@ -314,7 +314,7 @@
315315
316316 /**
317317 * Compatibility alias for getNextDatItem().
318 - * @deprecated Call getNextDataValue() or getNextDataItem() directly as needed. Method will vanish before SMW 1.7.
 318+ * @deprecated since 1.6. Call getNextDataValue() or getNextDataItem() directly as needed. Method will vanish before SMW 1.7.
319319 */
320320 public function getNextObject() {
321321 return $this->getNextDataValue();
@@ -323,6 +323,8 @@
324324 /**
325325 * Return the next SMWDataItem object or false if no further object exists.
326326 *
 327+ * @since 1.6
 328+ *
327329 * @return SMWDataItem or false
328330 */
329331 public function getNextDataItem() {
@@ -337,6 +339,8 @@
338340 * Return an SMWDataValue object for the next SMWDataItem object or
339341 * false if no further object exists.
340342 *
 343+ * @since 1.6
 344+ *
341345 * @return SMWDataValue or false
342346 */
343347 public function getNextDataValue() {
@@ -360,6 +364,8 @@
361365 *
362366 * @param integer $outputMode
363367 * @param mixed $linker
 368+ *
 369+ * @return string or false
364370 */
365371 public function getNextText( $outputMode, $linker = null ) {
366372 $dv = $this->getNextDataValue();
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Number.php
@@ -7,6 +7,8 @@
88 /**
99 * This class implements number data items.
1010 *
 11+ * @since 1.6
 12+ *
1113 * @author Markus Krötzsch
1214 * @ingroup SMWDataItems
1315 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Error.php
@@ -9,6 +9,8 @@
1010 * pass around lists of error messages within the application. They are not
1111 * meant to be stored or exported, but they can be useful to a user.
1212 *
 13+ * @since 1.6
 14+ *
1315 * @author Markus Krötzsch
1416 * @ingroup SMWDataItems
1517 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Bool.php
@@ -7,6 +7,8 @@
88 /**
99 * This class implements Boolean data items.
1010 *
 11+ * @since 1.6
 12+ *
1113 * @author Markus Krötzsch
1214 * @ingroup SMWDataItems
1315 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Concept.php
@@ -10,6 +10,8 @@
1111 * well vanish at some point since Container values could encode this data
1212 * just as well.
1313 *
 14+ * @since 1.6
 15+ *
1416 * @author Markus Krötzsch
1517 * @ingroup SMWDataItems
1618 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DataItem.php
@@ -18,6 +18,8 @@
1919
2020 /**
2121 * Exception to be thrown when data items are created from unsuitable inputs.
 22+ *
 23+ * @since 1.6
2224 */
2325 class SMWDataItemException extends Exception {
2426 }
@@ -37,6 +39,7 @@
3840 * such selection procedures -- they are nothing but data and provide only
3941 * minimal interfaces for accessing the stored data (or aspects of it).
4042 *
 43+ * @since 1.6
4144 *
4245 * @ingroup SMWDataItems
4346 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Blob.php
@@ -7,6 +7,8 @@
88 /**
99 * This class implements blob (long string) data items.
1010 *
 11+ * @since 1.6
 12+ *
1113 * @author Markus Krötzsch
1214 * @ingroup SMWDataItems
1315 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Time.php
@@ -22,6 +22,8 @@
2323 * (exactly) passed since a given date, but also for the location of leap
2424 * years.
2525 *
 26+ * @since 1.6
 27+ *
2628 * @author Markus Krötzsch
2729 * @ingroup SMWDataItems
2830 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_URI.php
@@ -7,6 +7,8 @@
88 /**
99 * This class implements URI data items.
1010 *
 11+ * @since 1.6
 12+ *
1113 * @author Markus Krötzsch
1214 * @ingroup SMWDataItems
1315 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_WikiPage.php
@@ -7,6 +7,8 @@
88 /**
99 * This class implements wiki page data items.
1010 *
 11+ * @since 1.6
 12+ *
1113 * @author Markus Krötzsch
1214 * @ingroup SMWDataItems
1315 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Property.php
@@ -11,6 +11,8 @@
1212 * predefined (built-in) properties, and maintains an association of
1313 * property IDs, localized labels, and aliases.
1414 *
 15+ * @since 1.6
 16+ *
1517 * @author Markus Krötzsch
1618 * @ingroup SMWDataItems
1719 */
Index: trunk/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_String.php
@@ -6,6 +6,8 @@
77
88 /**
99 * Exception to be thrown when input string is too long.
 10+ *
 11+ * @since 1.6
1012 */
1113 class SMWStringLengthException extends SMWDataItemException {
1214 public function __construct( $string ) {
@@ -16,6 +18,8 @@
1719 /**
1820 * This class implements (length restricted) string data items.
1921 *
 22+ * @since 1.6
 23+ *
2024 * @author Markus Krötzsch
2125 * @ingroup SMWDataItems
2226 */

Status & tagging log