r87050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87049‎ | r87050 | r87051 >
Date:22:01, 27 April 2011
Author:krinkle
Status:ok
Tags:
Comment:
Add curly braces around if() statement in collapsibleTabs; + double quotes to single quotes per conventions
Modified paths:
  • /trunk/extensions/ClickTracking/modules/ext.UserBuckets.js (modified) (history)
  • /trunk/extensions/Vector/modules/ext.vector.collapsibleTabs.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/modules/ext.UserBuckets.js
@@ -19,7 +19,7 @@
2020
2121 $.setupActiveBuckets = function(){
2222 var buckets = $.getBuckets();
23 - for ( iter in mw.activeCampaigns ) {
 23+ for ( var iter in mw.activeCampaigns ) {
2424 var campaign = mw.activeCampaigns[iter];
2525 // if bucket has been set, or bucket version is out of date,
2626 // set up a user bucket
Index: trunk/extensions/Vector/modules/ext.vector.collapsibleTabs.js
@@ -86,15 +86,20 @@
8787
8888 // Bind callback functions to animate our drop down menu in and out
8989 // and then call the collapsibleTabs function on the menu
90 - $( '#p-views ul' ).bind( "beforeTabCollapse", function() {
91 - if( $( '#p-cactions' ).css( 'display' ) == 'none' )
92 - $( "#p-cactions" ).addClass( "filledPortlet" ).removeClass( "emptyPortlet" )
93 - .find( 'h5' ).css( 'width','1px' ).animate( { 'width':'26px' }, 390 );
94 - } ).bind( "beforeTabExpand", function() {
95 - if( $( '#p-cactions li' ).length == 1 )
96 - $( "#p-cactions h5" ).animate( { 'width':'1px' }, 370, function() {
97 - $( this ).attr( 'style', '' ).parent().addClass( "emptyPortlet" ).removeClass( "filledPortlet" );
98 - });
 90+ $( '#p-views ul' ).bind( 'beforeTabCollapse', function() {
 91+ if ( $( '#p-cactions' ).css( 'display' ) == 'none' ) {
 92+ $( '#p-cactions' )
 93+ .addClass( 'filledPortlet' ).removeClass( 'emptyPortlet' )
 94+ .find( 'h5' )
 95+ .css( 'width','1px' ).animate( { 'width':'26px' }, 390 );
 96+ }
 97+ } ).bind( 'beforeTabExpand', function() {
 98+ if ( $( '#p-cactions li' ).length == 1 ) {
 99+ $( '#p-cactions h5' ).animate( { 'width':'1px' }, 370, function() {
 100+ $( this ).attr( 'style', '' )
 101+ .parent().addClass( 'emptyPortlet' ).removeClass( 'filledPortlet' );
 102+ });
 103+ }
99104 } ).collapsibleTabs( {
100105 expandCondition: function( eleWidth ) {
101106 if( rtl ){

Status & tagging log