r87043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87042‎ | r87043 | r87044 >
Date:20:34, 27 April 2011
Author:kaldari
Status:ok
Tags:
Comment:
fixing sloppy var scoping from r87002
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.FlickrChecker.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.FlickrChecker.js
@@ -33,9 +33,9 @@
3434 * @param upload - the upload object to set the deed for
3535 */
3636 checkFlickr: function( url, $selector, upload ) {
37 - photoIdMatches = url.match(/flickr.com\/photos\/[^\/]+\/([0-9]+)/);
 37+ var photoIdMatches = url.match(/flickr.com\/photos\/[^\/]+\/([0-9]+)/);
3838 if ( photoIdMatches && photoIdMatches[1] > 0 ) {
39 - photoId = photoIdMatches[1];
 39+ var photoId = photoIdMatches[1];
4040 $.getJSON(this.apiUrl+'&method=flickr.photos.getInfo&api_key='+this.apiKey+'&photo_id='+photoId+'&format=json&jsoncallback=?',
4141 function( data ) {
4242 if ( typeof data.photo != 'undefined' ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87002initial partially functioning version of FlickrCheckerkaldari07:00, 27 April 2011

Status & tagging log