r87039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87038‎ | r87039 | r87040 >
Date:20:05, 27 April 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 28719) Do not call mLinkHolders __destruct explicitly

Patch by Vitaliy Filippov
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -144,6 +144,7 @@
145145 * Tisane
146146 * Umherirrender
147147 * Ville Stadista
 148+* Vitaliy Filippov
148149 * Yuvaraj Pandian T
149150 * Zachary Hauri
150151
Index: trunk/phase3/includes/parser/Parser.php
@@ -182,7 +182,7 @@
183183 */
184184 function __destruct() {
185185 if ( isset( $this->mLinkHolders ) ) {
186 - $this->mLinkHolders->__destruct();
 186+ unset( $this->mLinkHolders );
187187 }
188188 foreach ( $this as $name => $value ) {
189189 unset( $this->$name );
Index: trunk/phase3/RELEASE-NOTES
@@ -253,6 +253,7 @@
254254 parsed messages.
255255 * (bug 27249) "Installed software" table in Special:Version should always be
256256 left-to-right.
 257+* (bug 28719) Do not call mLinkHolders __destruct explicitly
257258
258259 === API changes in 1.18 ===
259260 * (bug 26339) Throw warning when truncating an overlarge API result.

Status & tagging log