r86997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86996‎ | r86997 | r86998 >
Date:23:15, 26 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r86995
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/SM_GoogleMaps3.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayers.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/SM_GoogleMaps3.php
@@ -30,7 +30,7 @@
3131 );
3232
3333 $wgResourceModules['ext.sm.fi.googlemaps3'] = $moduleTemplate + array(
34 - 'dependencies' => array( 'ext.maps.googlemaps3' ),
 34+ 'dependencies' => array( 'ext.maps.googlemaps3', 'ext.sm.forminputs' ),
3535 'scripts' => array(
3636 'ext.sm.googlemapsinput.js'
3737 ),
@@ -42,12 +42,6 @@
4343 'jquery.googlemapsinput.js',
4444 ),
4545 'messages' => array(
46 - 'semanticmaps_enteraddresshere',
47 - 'semanticmaps-updatemap',
48 - 'semanticmaps_lookupcoordinates',
49 - 'semanticmaps-forminput-remove',
50 - 'semanticmaps-forminput-add',
51 - 'semanticmaps-forminput-locations'
5246 )
5347 );
5448 /*
Index: trunk/extensions/SemanticMaps/includes/services/YahooMaps/SM_YahooMaps.php
@@ -21,22 +21,14 @@
2222 }
2323
2424 $wgResourceModules['ext.sm.fi.yahoomaps'] = array(
25 - 'dependencies' => array( 'ext.maps.yahoomaps' ),
 25+ 'dependencies' => array( 'ext.maps.yahoomaps', 'ext.sm.forminputs' ),
2626 'localBasePath' => dirname( __FILE__ ),
27 - 'remoteBasePath' => $smgScriptPath . '/includes/services/OpenLayers',
 27+ 'remoteBasePath' => $smgScriptPath . '/includes/services/YahooMaps',
2828 'group' => 'ext.semanticmaps',
2929 'scripts' => array(
30 - 'jquery.openlayersinput.js',
31 - 'ext.sm.openlayersinput.js'
 30+ 'jquery.yahoomapsinput.js',
 31+ 'ext.sm.yahoomaps.js'
3232 ),
33 - 'messages' => array(
34 - 'semanticmaps_enteraddresshere',
35 - 'semanticmaps-updatemap',
36 - 'semanticmaps_lookupcoordinates',
37 - 'semanticmaps-forminput-remove',
38 - 'semanticmaps-forminput-add',
39 - 'semanticmaps-forminput-locations'
40 - )
4133 );
4234
4335 $wgHooks['MappingServiceLoad'][] = 'smfInitYahooMaps';
Index: trunk/extensions/SemanticMaps/includes/services/OpenLayers/SM_OpenLayers.php
@@ -21,21 +21,15 @@
2222 }
2323
2424 $wgResourceModules['ext.sm.fi.openlayers'] = array(
25 - 'dependencies' => array( 'ext.maps.openlayers' ),
 25+ 'dependencies' => array( 'ext.maps.openlayers', 'ext.sm.forminputs' ),
2626 'localBasePath' => dirname( __FILE__ ),
27 - 'remoteBasePath' => $smgScriptPath . '/includes/services/YahooMaps',
 27+ 'remoteBasePath' => $smgScriptPath . '/includes/services/OpenLayers',
2828 'group' => 'ext.semanticmaps',
2929 'scripts' => array(
30 - 'jquery.yahoomapsinput.js',
31 - 'ext.sm.yahoomapsinput.js'
 30+ 'jquery.openlayersinput.js',
 31+ 'ext.sm.openlayersinput.js'
3232 ),
3333 'messages' => array(
34 - 'semanticmaps_enteraddresshere',
35 - 'semanticmaps-updatemap',
36 - 'semanticmaps_lookupcoordinates',
37 - 'semanticmaps-forminput-remove',
38 - 'semanticmaps-forminput-add',
39 - 'semanticmaps-forminput-locations'
4034 )
4135 );
4236
Index: trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInputs.php
@@ -22,6 +22,12 @@
2323 'jquery.mapforminput.js'
2424 ),
2525 'messages' => array(
 26+ 'semanticmaps_enteraddresshere',
 27+ 'semanticmaps-updatemap',
 28+ 'semanticmaps_lookupcoordinates',
 29+ 'semanticmaps-forminput-remove',
 30+ 'semanticmaps-forminput-add',
 31+ 'semanticmaps-forminput-locations'
2632 )
2733 );
2834

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86995work on Yahoo! Maps form inputjeroendedauw23:05, 26 April 2011

Status & tagging log