r86926 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86925‎ | r86926 | r86927 >
Date:00:14, 26 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
some work on the yahoo maps form input
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/jquery.googlemapsinput.js (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/services/YahooMaps/jquery.yahoomapsinput.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/services/GoogleMaps3/jquery.googlemapsinput.js
@@ -57,7 +57,7 @@
5858 } );
5959 };
6060
61 - this.mapforminput( mapDivId, options, { canGeocode: true } );
 61+ this.mapforminput( mapDivId, options );
6262
6363 this.mapDiv.googlemaps( options );
6464
Index: trunk/extensions/SemanticMaps/includes/services/YahooMaps/jquery.yahoomapsinput.js
@@ -10,9 +10,34 @@
1111 */
1212
1313 (function( $ ){ $.fn.yahoomapsinput = function( options ) {
 14+
 15+ var self = this;
 16+ var geocoder = false;
 17+
 18+ /**
 19+ * Creates and places a new marker on the map at the provided
 20+ * coordinate set and the pans to it.
 21+ * @param {Object} coordinate
 22+ */
 23+ this.showCoordinate = function( coordinate ) {
 24+ // TODO
 25+ };
 26+
 27+ this.setupGeocoder = function() {
 28+ if ( geocoder === false ) {
 29+ // TODO
 30+ }
 31+ }
 32+
 33+ this.geocodeAddress = function( address ) {
 34+ this.setupGeocoder();
 35+ // TODO
 36+ };
 37+
 38+ this.mapforminput( mapDivId, options );
 39+
 40+ this.mapDiv.yahoomaps( options );
1441
15 -
16 -
1742 return this;
1843
1944 }; })( jQuery );
\ No newline at end of file

Status & tagging log