r86901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86900‎ | r86901 | r86902 >
Date:21:21, 25 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Added tracking for when a user rates an article but does not see a pitch.
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -640,6 +640,10 @@
641641 $.trackAction( prefix( 'pitch-' + key + '-show' ) );
642642 }
643643 } else {
 644+ // Track that a pitch was not presented
 645+ if ( tracked && typeof $.trackAction == 'function' ) {
 646+ $.trackAction( prefix( 'pitch-bypass' ) );
 647+ }
644648 // Give user some feedback that a save occured
645649 context.$ui.find( '.articleFeedback-success span' ).fadeIn( 'fast' );
646650 context.successTimeout = setTimeout( function() {

Status & tagging log