r86873 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86872‎ | r86873 | r86874 >
Date:17:52, 25 April 2011
Author:nimishg
Status:deferred
Tags:
Comment:
Changed JS to track attempts without creation of account
Modified paths:
  • /trunk/extensions/CustomUserSignup/modules/AccountCreationUserBucket.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CustomUserSignup/modules/AccountCreationUserBucket.js
@@ -46,15 +46,14 @@
4747 // "allActive" is reserved.
4848 // If this function exists, it will be apply to every user not in the "none" bucket
4949 "allActive": function(){
50 - if($j.cookie('acctcreation') ){
 50+
 51+ //track account creation attempts
 52+ $j("#wpCreateaccount").click(function(){ $j.trackAction('submit-signup-data'); });
5153
52 - //track login attempt
53 - $j("#wpLoginAttempt").click(function(){ $j.trackAction('login-attempt'); });
 54+ //this is the "don't have an account? CREATE ONE" link
 55+ $j("#userloginlink").click(function(){ $j.trackAction('visit-signup'); });
5456
55 - //track account creation
56 - $j("#wpCreateaccount").click(function(){ $j.trackAction('account-created'); });
57 - $j("#userloginlink").click(function(){ $j.trackAction('login-link'); });
58 -
 57+ if($j.cookie('acctcreation') ){
5958 //add click tracking to preview
6059 $j("#wpPreview").click(function(){ $j.trackAction('preview'); });
6160

Status & tagging log