r86871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86870‎ | r86871 | r86872 >
Date:17:34, 25 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Type hinting and documentation tweaks. This file is actually pretty good...
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
@@ -186,7 +186,7 @@
187187 * Given a set of conditions, fetch a revision from
188188 * the given database connection.
189189 *
190 - * @param $db Database
 190+ * @param $db DatabaseBase
191191 * @param $conditions Array
192192 * @return Revision or null
193193 */
@@ -226,7 +226,7 @@
227227 * which will return matching database rows with the
228228 * fields necessary to build Revision objects.
229229 *
230 - * @param $db Database
 230+ * @param $db DatabaseBase
231231 * @param $conditions Array
232232 * @return ResultWrapper
233233 */
@@ -587,7 +587,6 @@
588588 * Revision::FOR_THIS_USER to be displayed to $wgUser
589589 * Revision::RAW get the text regardless of permissions
590590 *
591 - *
592591 * @return String
593592 */
594593 public function getText( $audience = self::FOR_PUBLIC ) {
@@ -607,7 +606,7 @@
608607 * @return String
609608 */
610609 public function revText() {
611 - wfDeprecated();
 610+ wfDeprecated( __METHOD__ );
612611 return $this->getText( self::FOR_THIS_USER );
613612 }
614613
@@ -942,7 +941,7 @@
943942 * @param $pageId Integer: ID number of the page to read from
944943 * @param $summary String: revision's summary
945944 * @param $minor Boolean: whether the revision should be considered as minor
946 - * @return Mixed: Revision, or null on error
 945+ * @return Revision|null on error
947946 */
948947 public static function newNullRevision( $dbw, $pageId, $summary, $minor ) {
949948 wfProfileIn( __METHOD__ );

Status & tagging log