r86840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86839‎ | r86840 | r86841 >
Date:08:21, 25 April 2011
Author:nikerabbit
Status:deferred
Tags:
Comment:
Hopefully fix rtl issue
Modified paths:
  • /trunk/extensions/Translate/js/ext.translate.quickedit.css (modified) (history)
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/js/ext.translate.quickedit.css
@@ -23,7 +23,6 @@
2424 line-height: normal;
2525 margin: 0px;
2626 border: 1px solid #DBDBDB;
27 - text-align: left;
2827 }
2928
3029 .mw-sp-translate-edit-fields legend {
Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -748,8 +748,15 @@
749749
750750 $params = array( 'class' => 'mw-translate-edit-item' );
751751
 752+ $display = TranslateUtils::convertWhiteSpaceToHTML( $text );
 753+ $display = Html::rawElement( 'span', array(
 754+ 'lang' => $fbcode,
 755+ 'dir' => Language::factory( $fbcode )->getDir() ),
 756+ $display
 757+ );
 758+
752759 $contents = self::legend( $label ) . "\n" . $this->adder( $id ) .
753 - TranslateUtils::convertWhiteSpaceToHTML( $text ) . self::clear();
 760+ $display . self::clear();
754761
755762 $boxes[] = Html::rawElement( 'div', $params, $contents ) .
756763 $this->wrapInsert( $id, $text );

Status & tagging log