r86836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86835‎ | r86836 | r86837 >
Date:05:04, 25 April 2011
Author:yaron
Status:deferred
Tags:
Comment:
Follow-up to r86822 - fix for error
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -365,9 +365,7 @@
366366 $store = smwfGetStore();
367367 $requestoptions = new SMWRequestOptions();
368368 $requestoptions->limit = $sfgMaxAutocompleteValues;
369 - $property = SMWPropertyValue::makeProperty( $property_name );
370 - //$data_values = $store->getPropertyValues( null, $property, $requestoptions );
371 - $data_values = self::getSMWPropertyValues( $store, null, null, $property, $requestoptions );
 369+ $data_values = self::getSMWPropertyValues( $store, null, null, $property_name, $requestoptions );
372370 $values = array();
373371 foreach ( $data_values as $dv ) {
374372 // getPropertyValues() gets many repeat values - we want

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86822Added new function, SFUtils::getSMWPropertyValues() - wrapper around old and ...yaron17:23, 24 April 2011