r86820 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86819‎ | r86820 | r86821 >
Date:16:49, 24 April 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up r86813: fix exceptions seen on TWN. Ironically, I changed the CaptchaStore from an interface to an abstract class precisely to move into it the function which was throwing the exception... :D
Modified paths:
  • /trunk/extensions/ConfirmEdit/CaptchaStore.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmEdit/CaptchaStore.php
——@@ -42,7 +42,7 @@
4343 public final static function get() {
4444 if( !self::$instance instanceof self ){
4545 global $wgCaptchaStorageClass;
46 - if( in_array( 'CaptchaStore', class_implements( $wgCaptchaStorageClass ) ) ) {
 46+ if( in_array( 'CaptchaStore', class_parents( $wgCaptchaStorageClass ) ) ) {
4747 self::$instance = new $wgCaptchaStorageClass;
4848 } else {
4949 throw new MWException( "Invalid CaptchaStore class $wgCaptchaStorageClass" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r86825File missing from r86820. Actually these changes should have been committed ...happy-melon17:33, 24 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86813Introduce a CaptchaStore abstract class that CaptchaSessionStore and CaptchaC...happy-melon11:41, 24 April 2011

Comments

#Comment by Raymond (talk | contribs)   17:10, 24 April 2011

Still getting errors: 

[24-Apr-2011 17:09:47] /w/i.php?title=Mifos:Accounts-Account.returnToAccountDetails/fa&action=submit: Exception: Invalid CaptchaStore class CaptchaSessionStore
#0 /www/w/extensions/ConfirmEdit/ConfirmEditHooks.php(15): SimpleCaptcha->__construct()
#1 /www/w/extensions/ConfirmEdit/ConfirmEditHooks.php(25): ConfirmEditHooks::getInstance()
#2 [internal function]: ConfirmEditHooks::confirmEditMerged(Object(EditPage), '???????????? ??...', '', '')
#3 /www/w/includes/Hooks.php(235): call_user_func_array('ConfirmEditHook...', Array)
#4 /www/w/includes/Hooks.php(38): Hooks::run('EditFilterMerge...', Array)
#5 /www/w/includes/EditPage.php(961): wfRunHooks('EditFilterMerge...', Array)
#6 /www/w/includes/EditPage.php(2746): EditPage->internalAttemptSave(false, false)
#7 /www/w/includes/EditPage.php(457): EditPage->attemptSave()
#8 /www/w/includes/EditPage.php(335): EditPage->edit()
#9 /www/w/includes/Wiki.php(536): EditPage->submit()
#10 /www/w/includes/Wiki.php(104): MediaWiki->performAction(Object(Article))
#11 /www/w/index.php(145): MediaWiki->performRequestForTitle(Object(Article))

Status & tagging log