r86804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86803‎ | r86804 | r86805 >
Date:23:02, 23 April 2011
Author:reedy
Status:deferred
Tags:
Comment:
iwtransclusion/phase3: MFT r74206-75000

Ignoring tests, cause it's a conflicted mess
Modified paths:
  • /branches/iwtransclusion/phase3 (modified) (history)
  • /branches/iwtransclusion/phase3/RELEASE-NOTES (modified) (history)
  • /branches/iwtransclusion/phase3/includes (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Article.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Autopromote.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/BagOStuff.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Block.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/CacheDependency.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Categoryfinder.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ChangeTags.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ChangesList.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Defines.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/DistributionRepository.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/EditPage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Export.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/HTMLFileCache.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ImagePage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ImportXMLReader.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Interwiki.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/LinkBatch.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Linker.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/LinksUpdate.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/LogEventsList.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/MessageBlobStore.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/MessageCache.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/MimeMagic.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/OutputPage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/PoolCounter.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Preferences.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Profiler.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/ProfilerSimple.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/ProfilerSimpleText.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/ProfilerSimpleTrace.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/ProfilerSimpleUDP.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/ProfilerStub.php (replaced) (history)
  • /branches/iwtransclusion/phase3/includes/QueryPage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/RecentChange.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ResourceLoader.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ResourceLoaderContext.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/ResourceLoaderModule.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Revision.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/RevisionDelete.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/SeleniumWebSettings.php (added) (history)
  • /branches/iwtransclusion/phase3/includes/Skin.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/SquidUpdate.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Title.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/User.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/UserMailer.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/UserRightsProxy.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/WatchedItem.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/WatchlistEditor.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/WebStart.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Wiki.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/Xml.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiBase.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiDelete.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiFeedWatchlist.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiMain.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiPurge.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQuery.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryPageProps.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryRevisions.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiQueryUsers.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/api/ApiResult.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/Database.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabaseOracle.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabasePostgres.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/DatabaseSqlite.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/LocalFile.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/LocalRepo.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/filerepo/RepoGroup.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/CoreInstaller.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/OracleInstaller.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/PostgresInstaller.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/PostgresUpdater.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/SqliteInstaller.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/job/JobQueue.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/libs/CSSMin.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/media/Bitmap.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/memcached-client.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/CoreParserFunctions.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/CoreTagHooks.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/LinkHolderArray.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/Parser_DiffTest.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/parser/Preprocessor_Hash.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialAllmessages.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialBooksources.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialCategories.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialDisambiguations.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialExport.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialListfiles.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialMostlinked.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialMostlinkedcategories.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialMostlinkedtemplates.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialNewimages.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialNewpages.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialPreferences.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialProtectedpages.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialRevisionMove.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialSearch.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialTags.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialUndelete.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialUpload.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialWatchlist.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/specials/SpecialWhatlinkshere.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesAr.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesArc.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesAry.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesBa.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesBg.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesBjn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesBr.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesEt.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesIa.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesKn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesLg.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesLn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesLt.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesLv.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMdf.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMg.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMl.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMy.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesMzn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesNds.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesNds_nl.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesNn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesPms.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesPs.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesRm.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesRo.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesRoa_tara.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSa.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSc.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesScn.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesShi.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSq.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSv.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesSw.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesTa.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesTe.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesTg_cyrl.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesTh.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesTpi.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesUk.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesVec.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesWo.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesYo.php (modified) (history)
  • /branches/iwtransclusion/phase3/languages/messages/MessagesZh_hans.php (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/Maintenance.php (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/cleanupTable.inc (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/doMaintenance.php (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/helloWorld.php (deleted) (history)
  • /branches/iwtransclusion/phase3/maintenance/oracle/tables.sql (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/oracle/user.sql (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/postgres/compare_schemas.pl (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/purgeOldText.inc (modified) (history)
  • /branches/iwtransclusion/phase3/maintenance/tables.sql (modified) (history)
  • /branches/iwtransclusion/phase3/resources/Resources.php (modified) (history)
  • /branches/iwtransclusion/phase3/skins/MonoBook.php (modified) (history)
  • /branches/iwtransclusion/phase3/skins/common/search.js (modified) (history)
  • /branches/iwtransclusion/phase3/skins/monobook/external-ltr.png (added) (history)
  • /branches/iwtransclusion/phase3/skins/monobook/external.png (deleted) (history)
  • /branches/iwtransclusion/phase3/skins/monobook/main.css (modified) (history)
  • /branches/iwtransclusion/phase3/skins/vector/screen.css (modified) (history)

Status & tagging log