r86770 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86769‎ | r86770 | r86771 >
Date:14:11, 23 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Documentation

Fix call to undefined self::getTitleFor
Modified paths:
  • /trunk/phase3/includes/SpecialPageFactory.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPageFactory.php
@@ -153,6 +153,8 @@
154154 /**
155155 * Initialise the special page list
156156 * This must be called before accessing SpecialPage::$mList
 157+ *
 158+ * @return array
157159 */
158160 static function getList() {
159161 global $wgSpecialPages;
@@ -189,6 +191,9 @@
190192 return self::$mList;
191193 }
192194
 195+ /**
 196+ * @return array
 197+ */
193198 static function getAliasList() {
194199 if ( !is_object( self::$mAliases ) ) {
195200 global $wgContLang;
@@ -389,6 +394,8 @@
390395 * @param $title Title object
391396 * @param $context RequestContext
392397 * @param $including Bool output is being captured for use in {{special:whatever}}
 398+ *
 399+ * @return bool
393400 */
394401 public static function executePath( Title &$title, RequestContext &$context, $including = false ) {
395402 wfProfileIn( __METHOD__ );
@@ -455,6 +462,8 @@
456463 * Returns false if there was no such special page, or a title object if it was
457464 * a redirect.
458465 *
 466+ * @param $title Title
 467+ *
459468 * @return String: HTML fragment
460469 */
461470 static function capturePath( &$title ) {
@@ -515,12 +524,14 @@
516525 /**
517526 * Get a title for a given alias
518527 *
 528+ * @param $alias String
 529+ *
519530 * @return Title or null if there is no such alias
520531 */
521532 static function getTitleForAlias( $alias ) {
522533 $name = self::resolveAlias( $alias );
523534 if ( $name ) {
524 - return self::getTitleFor( $name );
 535+ return SpecialPage::getTitleFor( $name );
525536 } else {
526537 return null;
527538 }

Status & tagging log