r86748 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86747‎ | r86748 | r86749 >
Date:04:30, 23 April 2011
Author:neilk
Status:ok
Tags:
Comment:
should have been part of r86745 -- standardizing thumbnail size, layout across pages
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizard.config.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.config.php
@@ -186,29 +186,17 @@
187187
188188
189189 // Default thumbnail width
190 - 'thumbnailWidth' => 120,
 190+ 'thumbnailWidth' => 100,
191191
192192 // Max thumbnail height:
193 - 'thumbnailMaxHeight' => 200,
 193+ 'thumbnailMaxHeight' => 166,
194194
195 - // Min thumbnail width
196 - 'smallThumbnailWidth' => 60,
197 -
198 - // Small thumbnail max height
199 - 'smallThumbnailMaxHeight' => 100,
200 -
201195 // Large thumbnail width
202196 'largeThumbnailWidth' => 500,
203197
204198 // Large thumbnail max height
205199 'largeThumbnailMaxHeight' => 500,
206200
207 - // Icon thumbnail width:
208 - 'iconThumbnailWidth' => 32,
209 -
210 - // Icon thumbnail height:
211 - 'iconThumbnailMaxHeight' => 32,
212 -
213201 // Max author string length
214202 'maxAuthorLength' => 50,
215203
Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
@@ -263,12 +263,7 @@
264264 . '</div>'
265265
266266 . '<div class="mwe-upwiz-stepdiv" id="mwe-upwiz-stepdiv-details" style="display:none;">'
267 - . '<div id="mwe-upwiz-macro">'
268 - . '<div id="mwe-upwiz-macro-progress" class="ui-helper-clearfix"></div>'
269 - . '<div id="mwe-upwiz-macro-choice">'
270 - . '</div>'
271 - . '<div id="mwe-upwiz-macro-files"></div>'
272 - . '</div>'
 267+ . '<div id="mwe-upwiz-macro-files" class="mwe-upwiz-filled-filelist ui-corner-all"></div>'
273268 . '<div class="mwe-upwiz-buttons">'
274269 . '<button class="mwe-upwiz-button-next">' . wfMsg( "mwe-upwiz-next-details" ) . '</button>'
275270 . '</div>'

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86745standardizing on single thumbnail size, using layout similar to first page on...neilk01:38, 23 April 2011

Status & tagging log