r86744 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86743‎ | r86744 | r86745 >
Date:01:31, 23 April 2011
Author:neilk
Status:ok
Tags:
Comment:
in case there are other IE problems with this, moving all input types to be declared in the HTML, not in jquery attrs.
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.ApiUploadHandler.js (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js
@@ -51,8 +51,8 @@
5252
5353 var _this = new mw.UploadWizardDeed();
5454
55 - _this.authorInput = $j( '<input />')
56 - .attr( { name: "author", type: "text" } )
 55+ _this.authorInput = $j( '<input type="text" />' )
 56+ .attr( { name: "author" } )
5757 .addClass( 'mwe-upwiz-sign' );
5858
5959 var licenseInputDiv = $j( '<div class="mwe-upwiz-deed-license"></div>' );
@@ -93,7 +93,7 @@
9494
9595 _this.$form = $j( '<form />' );
9696
97 - var $authorInput2 = $j( '<input />' ).attr( { name: "author2", type: "text" } ).addClass( 'mwe-upwiz-sign' );
 97+ var $authorInput2 = $j( '<input type="text" />' ).attr( { name: "author2" } ).addClass( 'mwe-upwiz-sign' );
9898 var $standardDiv = $j( '<div />' ).append(
9999 $j( '<label for="author2" generated="true" class="mwe-validator-error" style="display:block;" />' ),
100100 $j( '<p></p>' ).msg( 'mwe-upwiz-source-ownwork-assert',
Index: trunk/extensions/UploadWizard/resources/mw.ApiUploadHandler.js
@@ -75,7 +75,7 @@
7676 */
7777 addFormInputIfMissing: function( name, value ) {
7878 if ( this.$form.find( "[name='" + name + "']" ).length === 0 ) {
79 - this.$form.append( $j( '<input />' ) .attr( { 'type': "hidden", 'name': name, 'value': value } ));
 79+ this.$form.append( $j( '<input type="hidden" />' ) .attr( { 'name': name, 'value': value } ));
8080 }
8181 },
8282

Status & tagging log