r86680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86679‎ | r86680 | r86681 >
Date:23:11, 21 April 2011
Author:yaron
Status:deferred
Tags:
Comment:
New version: 1.3
Modified paths:
  • /trunk/extensions/ExternalData/ExternalData.php (modified) (history)
  • /trunk/extensions/ExternalData/README (modified) (history)

Diff [purge]

Index: trunk/extensions/ExternalData/ExternalData.php
@@ -12,7 +12,7 @@
1313 $wgExtensionCredits['parserhook'][] = array(
1414 'path' => __FILE__,
1515 'name' => 'External Data',
16 - 'version' => '1.2.3',
 16+ 'version' => '1.3',
1717 'author' => array( 'Yaron Koren', 'Michael Dale', 'David Macdonald' ),
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:External_Data',
1919 'descriptionmsg' => 'externaldata-desc',
@@ -24,11 +24,11 @@
2525 if ( version_compare( $wgVersion, '1.16alpha', '>=' ) ) {
2626 $wgExtensionMessagesFiles['ExternalDataMagic'] = dirname(__FILE__) . '/ExternalData.i18n.magic.php';
2727 } else {
28 - // Pre 1.16alpha backward compatibility for magic words
 28+ // Pre-1.16alpha backward compatibility for magic words
2929 $wgHooks['LanguageGetMagic'][] = 'edgLanguageGetMagic';
3030 }
3131
32 -// register all special pages and other classes
 32+// Register all special pages and other classes
3333 $wgAutoloadClasses['EDUtils'] = dirname(__FILE__) . '/ED_Utils.php';
3434 $wgAutoloadClasses['EDParserFunctions'] = dirname(__FILE__) . '/ED_ParserFunctions.php';
3535 $wgSpecialPages['GetData'] = 'EDGetData';
@@ -40,7 +40,7 @@
4141 $edgCacheTable = null;
4242 $edgAllowSSL = true;
4343
44 -// (in seconds) set to one week:
 44+// Value is in seconds - set to one week
4545 $edgCacheExpireTime = 60 * 60 * 24 * 7;
4646
4747 $edgDBServer = array();
@@ -64,7 +64,7 @@
6565 return true; // always return true, in order not to stop MW's hook processing!
6666 }
6767
68 -// Pre 1.16alpha backward compatibility for magic words
 68+// Pre-1.16alpha backward compatibility for magic words
6969 function edgLanguageGetMagic( &$magicWords, $langCode = "en" ) {
7070 switch ( $langCode ) {
7171 default:
Index: trunk/extensions/ExternalData/README
@@ -1,6 +1,6 @@
22 External Data extension
33
4 - Version 1.2.3
 4+ Version 1.3
55 Yaron Koren, Michael Dale and David Macdonald
66
77 This is free software licensed under the GNU General Public License. Please
@@ -15,7 +15,8 @@
1616
1717 The extension defines seven parser functions - #get_web_data,
1818 #get_external_data, #get_db_data, #get_ldap_data, #external_value,
19 -#for_external_table and #store_external_table. They are described below:
 19+#for_external_table, #store_external_table and #clear_external_data.
 20+They are described below:
2021
2122 * #get_web_data retrieves the data from a URL that holds CSV, GFF,
2223 JSON or XML, and assigns it to local variables or arrays.
@@ -40,6 +41,8 @@
4142 any of the #get_*_data functions, in order to store the entire array
4243 of data semantically.
4344
 45+* #clear_external_data erases the current set of retrieved data.
 46+
4447 In addition, the extension defines a new special page, 'GetData', that
4548 exports selected rows from a wiki page that holds CSV data, in a format
4649 that is readable by #get_web_data.

Status & tagging log