r86612 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86611‎ | r86612 | r86613 >
Date:09:27, 21 April 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
fixed typo
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php
@@ -216,9 +216,9 @@
217217 public function getQueryString( $asvalue = false ) {
218218 $first = true;
219219 foreach ( $this->m_diWikiPages as $wikiPage ) {
220 - $wikiValue = SMWDataValueFactory::newFromDataItem( $wikiPage );
 220+ $wikiValue = SMWDataValueFactory::newDataItemValue( $wikiPage );
221221 if ( $first ) {
222 - $result .= '[[' . $wikiValue->getPrefixedText();
 222+ $result = '[[' . $wikiValue->getPrefixedText();
223223 $first = false;
224224 } else {
225225 $result .= '||' . $wikiValue->getText();
@@ -378,7 +378,7 @@
379379 $this->m_comparator = $comparator;
380380 }
381381
382 - /// @deprecated Use getDataItem() and SMWDataValueFactory::newFromDataItem() if needed. Vanishes before SMW 1.7
 382+ /// @deprecated Use getDataItem() and SMWDataValueFactory::newDataItemValue() if needed. Vanishes before SMW 1.7
383383 public function getDataValue() {
384384 return $this->m_dataItem;
385385 }
@@ -393,7 +393,7 @@
394394
395395 public function getQueryString( $asvalue = false ) {
396396 $comparator = SMWQueryLanguage::getStringForComparator( $this->m_comparator );
397 - $dataValue = SMWDataValueFactory::newFromDataItem( $this->m_dataItem );
 397+ $dataValue = SMWDataValueFactory::newDataItemValue( $this->m_dataItem );
398398 if ( $asvalue ) {
399399 return $comparator . $dataValue->getWikiValue();
400400 } else { // this only is possible for values of Type:Page

Status & tagging log