r86565 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86564‎ | r86565 | r86566 >
Date:23:12, 20 April 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Added some watchdog statements for finding missing trxns in paypal audit code
Modified paths:
  • /civicrm/trunk/sites/all/modules/paypal_audit/paypal_audit.module (modified) (history)

Diff [purge]

Index: civicrm/trunk/sites/all/modules/paypal_audit/paypal_audit.module
@@ -49,7 +49,7 @@
5050
5151 // find the 'tender type' and trxn id columns so we can tell paypal v payflow
5252 $columns = $report->getReportResponse()->findColumnNumber( array('Tender Type', 'Transaction ID', 'PayPal Transaction ID' ));
53 -
 53+ watchdog( 'paypal_audit', 'PayPal custom report run complete.', array(), WATCHDOG_DEBUG );
5454 //loop through trxns (each trxn is a reportDataRow object), isolate paypal v non-paypal
5555 foreach( $pp_trxns->getData() as $trxn ) {
5656 if ( $trxn[ $tt_column ] == 'PayPal' ) {
@@ -59,12 +59,17 @@
6060 }
6161 }
6262
 63+ watchdog( 'paypal_audit', 'PayPal transactions present in report: %d', array('%d' => count($pp_trxns)), WATCHDOG_DEBUG );
 64+ watchdog( 'paypal_audit', 'PayflowPro transactions present in report: %d', array('%d' => count($pfp_trxns)), WATCHDOG_DEBUG );
 65+
6366 //check for missing non-paypal
6467 $pp_trxns_missing = paypal_audit_find_missing_pp_trxns( $pp_trxns );
 68+ watchdog( 'paypal_audit', 'PayPal transactions missing: %d', array( '%d', count($pp_trxns_missing)), WATCHDOG_DEBUG );
6569 array_push( $missing_trxns, paypal_audit_format_trxns( $pp_trxns_missing, $report, 'PayPal' ));
6670
6771 //check for missing paypal
6872 $pf_trxns_missing = paypal_audit_find_missing_pf_trxns( $pf_trxns );
 73+ watchdog( 'paypal_audit', 'PayflowPro transactions missing: %d', array( '%d', count($pfp_trxns_missing)), WATCHDOG_DEBUG );
6974 array_push( $missing_trxns, paypal_audit_format_trxns( $pf_trxns_missing, $report ));
7075
7176 // add to $trxns and return

Status & tagging log