r86556 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86555‎ | r86556 | r86557 >
Date:22:24, 20 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
rem dead code
Modified paths:
  • /branches/Maps0.7.x/includes/features/Maps_BaseMap.php (modified) (history)

Diff [purge]

Index: branches/Maps0.7.x/includes/features/Maps_BaseMap.php
@@ -77,10 +77,6 @@
7878
7979 $output = $this->getMapHTML( $params, $parser );
8080
81 - if ( $egMapsUseRL ) {
82 - $output .= $this->getJSON( $params, $parser );
83 - }
84 -
8581 global $wgTitle;
8682 if ( !is_null( $wgTitle ) && $wgTitle->getNamespace() == NS_SPECIAL ) {
8783 global $wgOut;
@@ -94,41 +90,6 @@
9591 }
9692
9793 /**
98 - * Returns the JSON with the maps data.
99 - *
100 - * @since 0.7.3
101 - *
102 - * @param array $params
103 - * @param Parser $parser
104 - *
105 - * @return string
106 - */
107 - protected function getJSON( array $params, Parser $parser ) {
108 - $object = $this->getJSONObject( $params, $parser );
109 -
110 - if ( $object === false ) {
111 - return '';
112 - }
113 -
114 - // TODO
115 - return Html::inlineScript( "maps=[]; maps['{$this->service->getName()}']=[]; maps['{$this->service->getName()}'].push(" . json_encode( $object ) . ')' );
116 - }
117 -
118 - /**
119 - * Returns a PHP object to encode to JSON with the map data.
120 - *
121 - * @since 0.7.3
122 - *
123 - * @param array $params
124 - * @param Parser $parser
125 - *
126 - * @return mixed
127 - */
128 - protected function getJSONObject( array $params, Parser $parser ) {
129 - return $params;
130 - }
131 -
132 - /**
13394 * Translates the coordinates field to the centre field and makes sure it's set to it's default when invalid.
13495 */
13596 protected function setCentre( array &$params ) {

Status & tagging log