r86533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86532‎ | r86533 | r86534 >
Date:19:43, 20 April 2011
Author:krinkle
Status:ok
Tags:
Comment:
Follow-up r86532: Adding code to reset the form in the else case
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -268,7 +268,13 @@
269269 // If something was invalid, reset the helpimprove-email part of the form.
270270 // When user returns from submit, it will be clean
271271 } else {
272 -
 272+ $( '#articleFeedback-expertise-on' ).removeAttr('checked').change();
 273+ context.$ui
 274+ .find( '.articleFeedback-helpimprove-email' )
 275+ .val('')
 276+ .end()
 277+ .find( '.articleFeedback-helpimprove-email-validity' )
 278+ .remove();
273279 }
274280 },
275281 'executePitch': function( action ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86532Continue emailcapture + fix minor regression bug...krinkle19:36, 20 April 2011

Status & tagging log