r86531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86530‎ | r86531 | r86532 >
Date:19:34, 20 April 2011
Author:ialex
Status:deferred
Tags:
Comment:
Per Nikerabbit, 1.16 doesn't have Html::closeElement()
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialLanguageStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialLanguageStats.php
@@ -89,28 +89,28 @@
9090 $out .= Html::openElement( 'tr' );
9191 $out .= Html::openElement( 'td', array( 'class' => 'mw-label' ) );
9292 $out .= Xml::label( wfMsg( 'translate-language-code-field-name' ), 'code' );
93 - $out .= Html::closeElement( 'td' );
 93+ $out .= Xml::closeElement( 'td' );
9494 $out .= Html::openElement( 'td', array( 'class' => 'mw-input' ) );
9595 $out .= Xml::input( 'code', 30, str_replace( '_', ' ', $code ), array( 'id' => 'code' ) );
96 - $out .= Html::closeElement( 'td' );
97 - $out .= Html::closeElement( 'tr' );
 96+ $out .= Xml::closeElement( 'td' );
 97+ $out .= Xml::closeElement( 'tr' );
9898
9999 $out .= Html::openElement( 'tr' );
100100 $out .= Html::openElement( 'td', array( 'colspan' => 2 ) );
101101 $out .= Xml::checkLabel( wfMsg( 'translate-suppress-complete' ), 'suppresscomplete', 'suppresscomplete', $suppressComplete );
102 - $out .= Html::closeElement( 'td' );
103 - $out .= Html::closeElement( 'tr' );
 102+ $out .= Xml::closeElement( 'td' );
 103+ $out .= Xml::closeElement( 'tr' );
104104
105105 $out .= Html::openElement( 'tr' );
106106 $out .= Html::openElement( 'td', array( 'class' => 'mw-input', 'colspan' => 2 ) );
107107 $out .= Xml::submitButton( wfMsg( 'allpagessubmit' ) );
108 - $out .= Html::closeElement( 'td' );
109 - $out .= Html::closeElement( 'tr' );
 108+ $out .= Xml::closeElement( 'td' );
 109+ $out .= Xml::closeElement( 'tr' );
110110
111 - $out .= Html::closeElement( 'table' );
112 - $out .= Html::closeElement( 'fieldset' );
113 - $out .= Html::closeElement( 'form' );
114 - $out .= Html::closeElement( 'div' );
 111+ $out .= Xml::closeElement( 'table' );
 112+ $out .= Xml::closeElement( 'fieldset' );
 113+ $out .= Xml::closeElement( 'form' );
 114+ $out .= Xml::closeElement( 'div' );
115115
116116 return $out;
117117 }
@@ -187,7 +187,7 @@
188188 $out .= "\n\t\t" . Html::element( 'th', array( 'title' => self::newlineToWordSeparator( wfMsg( 'translate-untranslated-tooltip' ) ) ), wfMsg( 'translate-untranslated' ) );
189189 $out .= "\n\t\t" . Html::element( 'th', array( 'title' => self::newlineToWordSeparator( wfMsg( 'translate-percentage-complete-tooltip' ) ) ), wfMsg( 'translate-percentage-complete' ) );
190190 $out .= "\n\t\t" . Html::element( 'th', array( 'title' => self::newlineToWordSeparator( wfMsg( 'translate-percentage-fuzzy-tooltip' ) ) ), wfMsg( 'translate-percentage-fuzzy' ) );
191 - $out .= "\n\t" . Html::closeElement( 'tr' );
 191+ $out .= "\n\t" . Xml::closeElement( 'tr' );
192192
193193 return $out;
194194 }
@@ -217,7 +217,7 @@
218218
219219 if ( $out ) {
220220 $out = $this->createHeader( $code ) . "\n" . $out;
221 - $out .= Html::closeElement( 'table' );
 221+ $out .= Xml::closeElement( 'table' );
222222 } else {
223223 $out = wfMsgExt( 'translate-nothing-to-do', 'parse' );
224224 }
@@ -313,7 +313,7 @@
314314 $this->getBackgroundColour( $fuzzy, $total, true ),
315315 sprintf( '%1.3f', $fuzzy / $total ) );
316316
317 - $out .= "\n\t" . Html::closeElement( 'tr' ) . "\n";
 317+ $out .= "\n\t" . Xml::closeElement( 'tr' ) . "\n";
318318 return $out;
319319 }
320320

Status & tagging log