r86514 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86513‎ | r86514 | r86515 >
Date:17:57, 20 April 2011
Author:siebrand
Status:deferred
Tags:
Comment:
Swap incorrect backward compat fix from r86511.
Modified paths:
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -210,14 +210,13 @@
211211
212212 $options = $parser->getOptions();
213213
214 - // Backward compat for MediaWiki 1.17
215214 if ( method_exists( $options, 'getUserLang' ) ) {
216215 $userLangCode = $options->getUserLang();
217 - $sk = $options->getSkin();
218 - } else {
 216+ $sk = false;
 217+ } else { // Backward compat for MediaWiki 1.17
219218 global $wgLang;
220219 $userLangCode = $wgLang->getCode();
221 - $sk = false;
 220+ $sk = $options->getSkin();
222221 }
223222
224223 $languages = array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86511Changes for deprecated ParserOptions::getSkin() from r85296 and keeping backw...siebrand17:37, 20 April 2011

Status & tagging log