r86509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86508‎ | r86509 | r86510 >
Date:17:34, 20 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r86048: fix fatal, and deprecated Skin static method call.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListusers.php
@@ -129,7 +129,7 @@
130130 return '';
131131
132132 $userPage = Title::makeTitle( NS_USER, $row->user_name );
133 - $name = $this->getSkin()->link( $userPage, htmlspecialchars( $userPage->getText() ) );
 133+ $name = Linker::link( $userPage, htmlspecialchars( $userPage->getText() ) );
134134
135135 $groups_list = self::getGroups( $row->user_id );
136136 if( count( $groups_list ) > 0 ) {
@@ -305,7 +305,7 @@
306306 $s .= Html::rawElement( 'ul', array(), $usersbody );
307307 $s .= $up->getNavigationBar();
308308 } else {
309 - $s .= wfMessage( 'listusers-noresult' )->parseBlock();
 309+ $s .= wfMessage( 'listusers-noresult' )->parseAsBlock();
310310 }
311311
312312 $wgOut->addHTML( $s );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86048Recommit r84805, but without removing UsersPager, which is actually a Good Th...happy-melon13:27, 14 April 2011

Status & tagging log