r86483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86482‎ | r86483 | r86484 >
Date:15:30, 20 April 2011
Author:diebuche
Status:ok
Tags:
Comment:
Followup to r86056 per CR: No need to keep jQuery object, just set it to boolean true
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js
@@ -20,12 +20,12 @@
2121
2222 // this row has a checked radio button
2323 if ( $inputs.get(0).checked ) {
24 - oldLi = $this;
 24+ oldLi = true;
2525 $this.addClass( 'selected' );
2626 $inputs.eq(0).css( 'visibility', 'visible' );
2727 $inputs.eq(1).css( 'visibility', 'hidden' );
2828 } else if ( $inputs.get(1).checked ) {
29 - diffLi = $this;
 29+ diffLi = true;
3030 $this.addClass( 'selected' );
3131 $inputs.eq(0).css( 'visibility', 'hidden' );
3232 $inputs.eq(1).css( 'visibility', 'visible' );
@@ -37,8 +37,7 @@
3838 $inputs.eq(1).css( 'visibility', 'hidden' );
3939 } else if ( diffLi ) {
4040 // We're between the selected radios
41 - $inputs.eq(0).css( 'visibility', 'visible' );
42 - $inputs.eq(1).css( 'visibility', 'visible' );
 41+ $inputs.css( 'visibility', 'visible' );
4342 } else {
4443 // We're above the selected radios
4544 $inputs.eq(1).css( 'visibility', 'visible' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86056Followup to r86047: Rewrite the radio-button updater & move everything to act...diebuche16:06, 14 April 2011

Status & tagging log