r86481 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86480‎ | r86481 | r86482 >
Date:15:26, 20 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r86407: missed a file (and some random documentation); I'm surprised it worked without it.
Modified paths:
  • /trunk/phase3/includes/SpecialPageFactory.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPageFactory.php
@@ -414,25 +414,7 @@
415415 // Page exists, set the context
416416 $page->setContext( $context );
417417
418 - // Check for redirect
419418 if ( !$including ) {
420 - if( $page instanceof SpecialRedirectToSpecial ){
421 - $redirect = $page->getRedirect( $par );
422 - $query = $page->getRedirectQuery();
423 - if ( $redirect instanceof Title ) {
424 - $url = $redirect->getFullUrl( $query );
425 - $context->output->redirect( $url );
426 - wfProfileOut( __METHOD__ );
427 - return $redirect;
428 - } elseif ( $redirect === true ) {
429 - global $wgScript;
430 - $url = $wgScript . '?' . wfArrayToCGI( $query );
431 - $context->output->redirect( $url );
432 - wfProfileOut( __METHOD__ );
433 - return $redirect;
434 - }
435 - }
436 -
437419 // Redirect to canonical alias for GET commands
438420 // Not for POST, we'd lose the post data, so it's best to just distribute
439421 // the request. Such POST requests are possible for old extensions that
Index: trunk/phase3/includes/db/Database.php
@@ -1039,7 +1039,8 @@
10401040 * see DatabaseBase::makeSelectOptions code for list of supported stuff
10411041 * @param $join_conds Array: Associative array of table join conditions (optional)
10421042 * (e.g. array( 'page' => array('LEFT JOIN','page_latest=rev_id') )
1043 - * @return mixed Database result resource (feed to DatabaseBase::fetchObject or whatever), or false on failure
 1043+ * @return ResultWrapper|Bool Database result resource (feed to DatabaseBase::fetchObject
 1044+ * or whatever), or false on failure
10441045 */
10451046 function select( $table, $vars, $conds = '', $fname = 'DatabaseBase::select', $options = array(), $join_conds = array() ) {
10461047 $sql = $this->selectSQLText( $table, $vars, $conds, $fname, $options, $join_conds );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86407Follow-up r86255: don't special-case redirecting special pages in executePath...happy-melon15:45, 19 April 2011

Status & tagging log