r86449 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86448‎ | r86449 | r86450 >
Date:00:25, 20 April 2011
Author:neilk
Status:ok
Tags:
Comment:
make SpecialUpload::userCanExecute signature compatible with SpecialPage, which now uses type hinting
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
——@@ -140,7 +140,7 @@
141141 * @param $user User object
142142 * @return Boolean
143143 */
144 - public function userCanExecute( $user ) {
 144+ public function userCanExecute( User $user ) {
145145 return UploadBase::isEnabled() && parent::userCanExecute( $user );
146146 }
147147

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86255Refactor the factory/i18n/list/etc static methods from SpecialPage into their...happy-melon11:31, 17 April 2011

Status & tagging log