r86444 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86443‎ | r86444 | r86445 >
Date:23:29, 19 April 2011
Author:krinkle
Status:ok
Tags:
Comment:
Follow-up r86442; Add parentheses as shown in the original mockup, cache jQuery object
- remove mw.log call
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -506,22 +506,20 @@
507507 }, mw.msg('articlefeedback-form-panel-helpimprove-privacy')
508508 );
509509 return mw.html.escape( mw.msg( 'articlefeedback-form-panel-helpimprove-note') )
510 - .replace( /\$1/, link );
 510+ .replace( /\$1/, mw.message( 'parentheses', link ).toString() );
511511 })
512512 .end()
513513 .find( '.articleFeedback-helpimprove-email' )
514514 .attr( 'placeholder', mw.msg( 'articlefeedback-form-panel-helpimprove-email-placeholder' ) )
515515 .placeholder() // back. compat. for older browsers
516 -
517 - // Basically from mediawiki.special.preferences.js
518516 .one( 'blur', function() {
 517+ var $el = $(this), val = $el.val();
519518 if ( context.$ui.find( '.articleFeedback-helpimprove-email-validity' ).length === 0 ) {
520 - $(this).after( '<div class="articleFeedback-helpimprove-email-validity"></div>' );
 519+ $el.after( '<div class="articleFeedback-helpimprove-email-validity"></div>' );
521520 }
522 - updateMailValidityLabel( $(this).val(), context );
523 - mw.log(context);
524 - $(this).keyup( function() {
525 - updateMailValidityLabel( $(this).val(), context );
 521+ updateMailValidityLabel( val, context );
 522+ $el.keyup( function() {
 523+ updateMailValidityLabel( val, context );
526524 } );
527525 } )
528526 .end()

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86442Start of EmailCapture front-end...krinkle23:11, 19 April 2011

Status & tagging log