r86378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86377‎ | r86378 | r86379 >
Date:06:46, 19 April 2011
Author:kaldari
Status:ok
Tags:
Comment:
moving date out of more options
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardDetails.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardDetails.js
@@ -126,14 +126,10 @@
127127 name: categoriesId,
128128 type: 'text' } )
129129 );
130 -
131 - var moreDetailsDiv = $j('<div class="mwe-more-details"></div>');
132130
133 - var moreDetailsCtrlDiv = $j( '<div class="mwe-upwiz-details-more-options"></div>' );
134 -
135131 var dateInputId = "dateInput" + ( _this.upload.index ).toString();
136132 var dateDisplayInputId = "dateDisplayInput" + ( _this.upload.index ).toString();
137 -
 133+
138134 var dateErrorDiv = $j('<div class="mwe-upwiz-details-input-error"><label class="mwe-validator-error" for="' + dateInputId + '" generated="true"/></div>');
139135
140136 /* XXX must localize this by loading jquery.ui.datepicker-XX.js where XX is a language code */
@@ -143,7 +139,6 @@
144140 $j( '<input type="text" id="' + dateInputId + '" name="' + dateInputId + '" type="text" class="mwe-date" size="20"/>' );
145141 _this.dateDisplayInput =
146142 $j( '<input type="text" id="' + dateDisplayInputId + '" name="' + dateDisplayInputId + '" type="text" class="mwe-date-display" size="20"/>' );
147 -
148143
149144 var dateInputDiv = $j( '<div class="mwe-upwiz-details-fieldname-input ui-helper-clearfix"></div>' )
150145 .append(
@@ -151,6 +146,10 @@
152147 $j( '<div class="mwe-upwiz-details-fieldname"></div>' ).append( gM( 'mwe-upwiz-date-created' ) ),
153148 $j( '<div class="mwe-upwiz-details-input"></div>' ).append( _this.dateInput, _this.dateDisplayInput ) );
154149
 150+ var moreDetailsCtrlDiv = $j( '<div class="mwe-upwiz-details-more-options"></div>' );
 151+
 152+ var moreDetailsDiv = $j('<div class="mwe-more-details"></div>');
 153+
155154 var otherInformationId = "otherInformation" + _this.upload.index;
156155 _this.otherInformationInput = $j( '<textarea id="' + otherInformationId + '" name="' + otherInformationId + '" class="mwe-upwiz-other-textarea"></textarea>' )
157156 .growTextArea();
@@ -160,7 +159,6 @@
161160 .append( _this.otherInformationInput );
162161
163162 $j( moreDetailsDiv ).append(
164 - dateInputDiv,
165163 // location goes here
166164 otherInformationDiv
167165 );
@@ -174,6 +172,7 @@
175173 descriptionAdderDiv,
176174 _this.copyrightInfoFieldset,
177175 $categoriesDiv,
 176+ dateInputDiv,
178177 moreDetailsCtrlDiv,
179178 moreDetailsDiv
180179 );

Status & tagging log