r86221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86220‎ | r86221 | r86222 >
Date:17:25, 16 April 2011
Author:bawolff
Status:ok
Tags:
Comment:
(follow-up r86169) per Reedy, the $val = $val thing is weird.

Most of these were actually here going way way back to the dark ages
(although they were hidden as $tags[$tag] = $val; with $val being the same as $tags[$tag])
Modified paths:
  • /trunk/phase3/includes/media/FormatMetadata.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/FormatMetadata.php
——@@ -127,7 +127,7 @@
128128 $val = self::msg( $tag, $val );
129129 break;
130130 default:
131 - $val = $val;
 131+ /* If not recognized, display as is. */
132132 break;
133133 }
134134 break;
——@@ -138,7 +138,7 @@
139139 $val = self::msg( $tag, $val );
140140 break;
141141 default:
142 - $val = $val;
 142+ /* If not recognized, display as is. */
143143 break;
144144 }
145145 break;
——@@ -149,7 +149,7 @@
150150 $val = self::msg( $tag, $val );
151151 break;
152152 default:
153 - $val = $val;
 153+ /* If not recognized, display as is. */
154154 break;
155155 }
156156 break;
——@@ -160,7 +160,7 @@
161161 $val = self::msg( $tag, $val );
162162 break;
163163 default:
164 - $val = $val;
 164+ /* If not recognized, display as is. */
165165 break;
166166 }
167167 break;
——@@ -173,7 +173,7 @@
174174 $val = self::msg( $tag, $val );
175175 break;
176176 default:
177 - $val = $val;
 177+ /* If not recognized, display as is. */
178178 break;
179179 }
180180 break;
——@@ -188,7 +188,7 @@
189189 $val = self::msg( 'XYResolution', 'c', self::formatNum( $val ) );
190190 break;
191191 default:
192 - $val = $val;
 192+ /* If not recognized, display as is. */
193193 break;
194194 }
195195 break;
——@@ -204,7 +204,7 @@
205205 $val = self::msg( $tag, $val );
206206 break;
207207 default:
208 - $val = $val;
 208+ /* If not recognized, display as is. */
209209 break;
210210 }
211211 break;
——@@ -215,7 +215,7 @@
216216 $val = self::msg( $tag, $val );
217217 break;
218218 default:
219 - $val = $val;
 219+ /* If not recognized, display as is. */
220220 break;
221221 }
222222 break;
——@@ -254,7 +254,7 @@
255255 $val = self::msg( $tag, $val );
256256 break;
257257 default:
258 - $val = $val;
 258+ /* If not recognized, display as is. */
259259 break;
260260 }
261261 break;
——@@ -269,7 +269,7 @@
270270 $val = self::msg( $tag, $val );
271271 break;
272272 default:
273 - $val = $val;
 273+ /* If not recognized, display as is. */
274274 break;
275275 }
276276 break;
——@@ -282,7 +282,7 @@
283283 $val = self::msg( $tag, $val );
284284 break;
285285 default:
286 - $val = $val;
 286+ /* If not recognized, display as is. */
287287 break;
288288 }
289289 break;
——@@ -315,7 +315,7 @@
316316 $val = self::msg( $tag, $val );
317317 break;
318318 default:
319 - $val = $val;
 319+ /* If not recognized, display as is. */
320320 break;
321321 }
322322 break;
——@@ -326,7 +326,7 @@
327327 $val = self::msg( $tag, $val );
328328 break;
329329 default:
330 - $val = $val;
 330+ /* If not recognized, display as is. */
331331 break;
332332 }
333333 break;
——@@ -337,7 +337,7 @@
338338 $val = self::msg( $tag, $val );
339339 break;
340340 default:
341 - $val = $val;
 341+ /* If not recognized, display as is. */
342342 break;
343343 }
344344 break;
——@@ -348,7 +348,7 @@
349349 $val = self::msg( $tag, $val );
350350 break;
351351 default:
352 - $val = $val;
 352+ /* If not recognized, display as is. */
353353 break;
354354 }
355355 break;
——@@ -359,7 +359,7 @@
360360 $val = self::msg( $tag, $val );
361361 break;
362362 default:
363 - $val = $val;
 363+ /* If not recognized, display as is. */
364364 break;
365365 }
366366 break;
——@@ -370,7 +370,7 @@
371371 $val = self::msg( $tag, $val );
372372 break;
373373 default:
374 - $val = $val;
 374+ /* If not recognized, display as is. */
375375 break;
376376 }
377377 break;
——@@ -381,7 +381,7 @@
382382 $val = self::msg( $tag, $val );
383383 break;
384384 default:
385 - $val = $val;
 385+ /* If not recognized, display as is. */
386386 break;
387387 }
388388 break;
——@@ -392,7 +392,7 @@
393393 $val = self::msg( $tag, $val );
394394 break;
395395 default:
396 - $val = $val;
 396+ /* If not recognized, display as is. */
397397 break;
398398 }
399399 break;
——@@ -403,7 +403,7 @@
404404 $val = self::msg( $tag, $val );
405405 break;
406406 default:
407 - $val = $val;
 407+ /* If not recognized, display as is. */
408408 break;
409409 }
410410 break;
——@@ -414,7 +414,7 @@
415415 $val = self::msg( $tag, $val );
416416 break;
417417 default:
418 - $val = $val;
 418+ /* If not recognized, display as is. */
419419 break;
420420 }
421421 break;
——@@ -425,7 +425,7 @@
426426 $val = self::msg( $tag, $val );
427427 break;
428428 default:
429 - $val = $val;
 429+ /* If not recognized, display as is. */
430430 break;
431431 }
432432 break;
——@@ -436,7 +436,7 @@
437437 $val = self::msg( $tag, $val );
438438 break;
439439 default:
440 - $val = $val;
 440+ /* If not recognized, display as is. */
441441 break;
442442 }
443443 break;
——@@ -447,7 +447,7 @@
448448 $val = self::msg( $tag, $val );
449449 break;
450450 default:
451 - $val = $val;
 451+ /* If not recognized, display as is. */
452452 break;
453453 }
454454 break;
——@@ -460,7 +460,7 @@
461461 $val = self::msg( 'GPSLatitude', $val );
462462 break;
463463 default:
464 - $val = $val;
 464+ /* If not recognized, display as is. */
465465 break;
466466 }
467467 break;
——@@ -472,7 +472,7 @@
473473 $val = self::msg( 'GPSLongitude', $val );
474474 break;
475475 default:
476 - $val = $val;
 476+ /* If not recognized, display as is. */
477477 break;
478478 }
479479 break;
——@@ -491,7 +491,7 @@
492492 $val = self::msg( $tag, $val );
493493 break;
494494 default:
495 - $val = $val;
 495+ /* If not recognized, display as is. */
496496 break;
497497 }
498498 break;
——@@ -502,7 +502,7 @@
503503 $val = self::msg( $tag, $val );
504504 break;
505505 default:
506 - $val = $val;
 506+ /* If not recognized, display as is. */
507507 break;
508508 }
509509 break;
——@@ -516,7 +516,7 @@
517517 $val = self::msg( 'GPSDirection', $val );
518518 break;
519519 default:
520 - $val = $val;
 520+ /* If not recognized, display as is. */
521521 break;
522522 }
523523 break;
——@@ -536,7 +536,7 @@
537537 $val = self::msg( 'GPSSpeed', $val );
538538 break;
539539 default:
540 - $val = $val;
 540+ /* If not recognized, display as is. */
541541 break;
542542 }
543543 break;
——@@ -547,7 +547,7 @@
548548 $val = self::msg( 'GPSDestDistance', $val );
549549 break;
550550 default:
551 - $val = $val;
 551+ /* If not recognized, display as is. */
552552 break;
553553 }
554554 break;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86169Merge to trunk everything in img_metadata branch....bawolff01:23, 16 April 2011

Status & tagging log