r86176 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86175‎ | r86176 | r86177 >
Date:02:24, 16 April 2011
Author:aaron
Status:ok
Tags:
Comment:
* Replaced NS_IMAGE -> NS_FILE
* PHP param doc fix
Modified paths:
  • /trunk/extensions/FlaggedRevs/dataclasses/FRParserCacheStable.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/maintenance/updateTracking.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/maintenance/updateTracking.inc
@@ -42,7 +42,7 @@
4343 }
4444 $time = $sha1 = $file = null;
4545 # Check for file version to see if it's stored the old way...
46 - if ( !$row->fr_img_name && $row->page_namespace == NS_IMAGE ) {
 46+ if ( !$row->fr_img_name && $row->page_namespace == NS_FILE ) {
4747 $irow = $db->selectRow( 'flaggedimages',
4848 array( 'fi_img_timestamp', 'fi_img_sha1' ),
4949 array( 'fi_rev_id' => $row->fr_rev_id,
@@ -62,7 +62,7 @@
6363 $file = $crow ? $row->page_title : null;
6464 }
6565 # Leave it alone if already set
66 - } elseif ( $row->fr_img_name && $row->page_namespace == NS_IMAGE ) {
 66+ } elseif ( $row->fr_img_name && $row->page_namespace == NS_FILE ) {
6767 $time = $row->fr_img_timestamp;
6868 $sha1 = $row->fr_img_sha1;
6969 $file = $row->fr_img_name;
Index: trunk/extensions/FlaggedRevs/dataclasses/FRParserCacheStable.php
@@ -18,7 +18,7 @@
1919 /**
2020 * Like ParserCache::getParserOutputKey() with stable-pcache instead of pcache
2121 * @param $article Article
22 - * @param $hash
 22+ * @param $hash string
2323 * @return mixed|string
2424 */
2525 protected function getParserOutputKey( $article, $hash ) {

Status & tagging log