r86156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86155‎ | r86156 | r86157 >
Date:23:30, 15 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix indenting
Modified paths:
  • /trunk/extensions/ProofreadPage/SpecialPagesWithoutScans.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/SpecialPagesWithoutScans.php
@@ -58,20 +58,18 @@
5959 }
6060 $linkBatch->addObj( $dp );
6161 } else {
62 - # Get all the templates linked from the Mediawiki:Disambiguationspage
63 - $disPageObj = Title::makeTitleSafe( NS_MEDIAWIKI, 'disambiguationspage' );
64 - $res = $dbr->select(
65 - array('pagelinks', 'page'),
66 - 'pl_title',
67 - array('page_id = pl_from', 'pl_namespace' => NS_TEMPLATE,
68 - 'page_namespace' => $disPageObj->getNamespace(), 'page_title' => $disPageObj->getDBkey()),
69 - __METHOD__ );
 62+ # Get all the templates linked from the Mediawiki:Disambiguationspage
 63+ $disPageObj = Title::makeTitleSafe( NS_MEDIAWIKI, 'disambiguationspage' );
 64+ $res = $dbr->select(
 65+ array('pagelinks', 'page'),
 66+ 'pl_title',
 67+ array('page_id = pl_from', 'pl_namespace' => NS_TEMPLATE,
 68+ 'page_namespace' => $disPageObj->getNamespace(), 'page_title' => $disPageObj->getDBkey()),
 69+ __METHOD__ );
7070
71 - foreach ( $res as $row ) {
72 - $linkBatch->addObj( Title::makeTitle( NS_TEMPLATE, $row->pl_title ));
73 - }
74 -
75 - $dbr->freeResult( $res );
 71+ foreach ( $res as $row ) {
 72+ $linkBatch->addObj( Title::makeTitle( NS_TEMPLATE, $row->pl_title ));
 73+ }
7674 }
7775 return $linkBatch->constructSet( 'tl', $dbr );
7876 }

Status & tagging log