r86138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86137‎ | r86138 | r86139 >
Date:20:57, 15 April 2011
Author:bawolff
Status:ok
Tags:
Comment:
(bug 28561 - follow-up r4185) remove rule .small * {font-size: 94%} causes anything nested to be super-small

I'm not sure what the intent was, but this rule will make something like:
<span class="small">fo<b>o</b></span>
have the second o in foo be smaller then the first. Even without this rule, nested instances
of class="small" will still be smaller than a single instance, so it only causes weirdness.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/oldshared.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
@@ -237,7 +237,7 @@
238238 margin-right: auto;
239239 }
240240 /* small for tables and similar */
241 -.small, .small * { font-size: 94%; }
 241+.small { font-size: 94%; }
242242 table.small { font-size: 100% }
243243
244244 /*
Index: trunk/phase3/skins/monobook/main.css
@@ -317,7 +317,7 @@
318318 margin-right: auto;
319319 }
320320 /* small for tables and similar */
321 -.small, .small * {
 321+.small {
322322 font-size: 94%;
323323 }
324324 table.small {
Index: trunk/phase3/skins/common/oldshared.css
@@ -214,7 +214,7 @@
215215 }
216216
217217 /* small for tables and similar */
218 -.small, .small * {
 218+.small {
219219 font-size: 94%;
220220 }
221221 table.small {
Index: trunk/phase3/skins/vector/screen.css
@@ -1018,7 +1018,7 @@
10191019 margin-right: auto;
10201020 }
10211021 /* Small for tables and similar */
1022 -.small, .small * {
 1022+.small {
10231023 font-size: 94%;
10241024 }
10251025 table.small {
Index: trunk/phase3/RELEASE-NOTES
@@ -238,6 +238,7 @@
239239 * (bug 28444) Fix regression: edit-on-doubleclick retains revision id again
240240 * &apos; character entity is now allowed in wikitext
241241 * UtfNormal::cleanUp on an invalid utf-8 sequence no longer returns false if intl installed.
 242+* (bug 28561) The css class small will no longer make nested elements even smaller.
242243
243244 === API changes in 1.18 ===
244245 * (bug 26339) Throw warning when truncating an overlarge API result

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r4185.small classgabrielwicke09:17, 28 June 2004

Status & tagging log