r86099 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86098‎ | r86099 | r86100 >
Date:23:27, 14 April 2011
Author:reedy
Status:deferred
Tags:
Comment:
Fix another strict

Remove some unused variables
Modified paths:
  • /trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/Exhibit/SRF_Exhibit.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/Math/SRF_Math.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Math/SRF_Math.php
@@ -24,9 +24,6 @@
2525 }
2626
2727 protected function getResultText( $res, $outputmode ) {
28 - global $wgUser;
29 - $skin = $wgUser->getSkin();
30 -
3128 // initialize all necessary variables
3229 $sum = 0;
3330 $count = 0;
Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php
@@ -109,11 +109,7 @@
110110 global $wgGraphVizSettings;
111111 $wgGraphVizSettings = new GraphVizSettings;
112112 $this->isHTML = true;
113 -
114 - $key = 0;
115 -
116 - $legendInput = '';
117 -
 113+
118114 $graphInput = "digraph $this->m_graphName {";
119115 if ( $this->m_graphSize != '' ) $graphInput .= "size=\"$this->m_graphSize\";"; // pack=true; layout=dot;
120116 if ( $this->m_nodeShape ) $graphInput .= "node [shape=$this->m_nodeShape];";
Index: trunk/extensions/SemanticResultFormats/Exhibit/SRF_Exhibit.php
@@ -63,7 +63,6 @@
6464 $remote = true;
6565
6666 // fetch interwiki link
67 - $list = array();
6867 $dbr = &wfGetDB( DB_SLAVE );
6968 $cl = $dbr->tableName( 'interwiki' );
7069 $dbres = $dbr->select( $cl, 'iw_url', "iw_prefix='" . $this->m_params['remote'] . "'", __METHOD__, array() );
Index: trunk/extensions/SemanticResultFormats/Calendar/SRF_Calendar.php
@@ -58,7 +58,6 @@
5959 protected function getResultText( $res, $outputmode ) {
6060 global $wgUser;
6161 $skin = $wgUser->getSkin();
62 - $result = '';
6362
6463 $events = array();
6564 // print all result rows
@@ -377,7 +376,6 @@
378377 $days_in_prev_month = SRFCHistoricalDate::daysInMonth( $prev_year, $prev_month_num );
379378 $days_in_cur_month = SRFCHistoricalDate::daysInMonth( $cur_year, $cur_month_num );
380379 $today_string = date( 'Y n j', time() );
381 - $url_year = $wgRequest->getVal( 'year' );
382380 $page_name = $page_title->getPrefixedDbKey();
383381
384382 // Create table for holding title and navigation information.
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php
@@ -85,7 +85,7 @@
8686 );
8787 }
8888
89 - protected function loadJavascriptAndCSS() {
 89+ protected static function loadJavascriptAndCSS() {
9090 global $wgOut;
9191 $wgOut->addModules( 'ext.srf.jqplot' );
9292 $wgOut->addModules( 'ext.srf.jqplotbar' );

Status & tagging log