r86050 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86049‎ | r86050 | r86051 >
Date:13:52, 14 April 2011
Author:diebuche
Status:ok
Tags:
Comment:
Followup to r86047: Declare dependency to JUI button more cleanly
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js
@@ -5,7 +5,5 @@
66 // Replaces histrowinit
77 $( '#pagehistory li input[name="diff"], #pagehistory li input[name="oldid"]' ).click( diffcheck );
88 diffcheck();
9 - mediaWiki.loader.using('jquery.ui.button', function() {
10 - window.fixCompare();
11 - });
 9+ window.fixCompare();
1210 });
\ No newline at end of file
Index: trunk/phase3/resources/Resources.php
@@ -550,7 +550,7 @@
551551 'group' => 'mediawiki.action.history',
552552 'remoteBasePath' => $GLOBALS['wgStylePath'],
553553 'localBasePath' => "{$GLOBALS['IP']}/skins",
554 - 'dependencies' => 'mediawiki.legacy.wikibits',
 554+ 'dependencies' => array( 'mediawiki.legacy.wikibits', 'jquery.ui.button' ),
555555 ),
556556 'mediawiki.legacy.IEFixes' => array(
557557 'scripts' => 'common/IEFixes.js',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86047History: Adding JS that converts buttons to links for better UX. Patch based...diebuche13:18, 14 April 2011

Status & tagging log