r86030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86029‎ | r86030 | r86031 >
Date:07:14, 14 April 2011
Author:tstarling
Status:ok
Tags:
Comment:
* MFT r86027: fix IE6 XSS again
* Updates for release of 1.16.4
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/images/.htaccess (modified) (history)
  • /branches/REL1_16/phase3/img_auth.php (modified) (history)
  • /branches/REL1_16/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_16/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/images/.htaccess
@@ -1,6 +1,6 @@
22 # Protect against bug 28235
33 <IfModule rewrite_module>
44 RewriteEngine On
5 - RewriteCond %{QUERY_STRING} \.[a-z]{1,4}$ [nocase]
 5+ RewriteCond %{QUERY_STRING} \.[a-z0-9]{1,4}(#|\?|$) [nocase]
66 RewriteRule . - [forbidden]
77 </IfModule>
Index: branches/REL1_16/phase3/includes/WebRequest.php
@@ -697,7 +697,7 @@
698698 global $wgScriptExtension;
699699
700700 if ( isset( $_SERVER['QUERY_STRING'] )
701 - && preg_match( '/\.[a-z]{1,4}$/i', $_SERVER['QUERY_STRING'] ) )
 701+ && preg_match( '/\.[a-z0-9]{1,4}(#|\?|$)/i', $_SERVER['QUERY_STRING'] ) )
702702 {
703703 // Bug 28235
704704 // Block only Internet Explorer, and requests with missing UA
Index: branches/REL1_16/phase3/includes/DefaultSettings.php
@@ -33,7 +33,7 @@
3434 }
3535
3636 /** MediaWiki version number */
37 -$wgVersion = '1.16.3';
 37+$wgVersion = '1.16.4';
3838
3939 /** Name of the site. It must be changed in LocalSettings.php */
4040 $wgSitename = 'MediaWiki';
Index: branches/REL1_16/phase3/img_auth.php
@@ -39,7 +39,7 @@
4040
4141 // Check for bug 28235: QUERY_STRING overriding the correct extension
4242 if ( isset( $_SERVER['QUERY_STRING'] )
43 - && preg_match( '/\.[a-z]{1,4}$/i', $_SERVER['QUERY_STRING'] ) )
 43+ && preg_match( '/\.[a-z0-9]{1,4}(#|\?|$)/i', $_SERVER['QUERY_STRING'] ) )
4444 {
4545 wfForbidden( 'img-auth-accessdenied', 'img-auth-bad-query-string' );
4646 }
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -1,8 +1,8 @@
22 = MediaWiki release notes =
33
4 -== MediaWiki 1.16.3 ==
 4+== MediaWiki 1.16.4 ==
55
6 -2011-04-12
 6+2011-04-14
77
88 This is a security and maintenance release of the MediaWiki 1.16 branch.
99
@@ -44,6 +44,12 @@
4545 you have the DBA extension for PHP installed, this will improve performance
4646 further.
4747
 48+== Changes since 1.16.3 ==
 49+
 50+* (bug 28507) The change we made in 1.16.3 to fix bug 28235 (XSS for IE 6
 51+ clients) was not actually sufficient to fix that bug. This release contains
 52+ a second attempt, hopefully we have fixed it this time.
 53+
4854 == Changes since 1.16.2 ==
4955
5056 * (bug 28449) Fixed permissions checks in Special:Import which allowed users

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86027(bug 28507) Fix for r85844: that revision was not actually sufficient to fix ...tstarling07:10, 14 April 2011

Status & tagging log