r86007 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86006‎ | r86007 | r86008 >
Date:23:25, 13 April 2011
Author:catrope
Status:ok
Tags:
Comment:
ArticleFeedback: Remove array() around lone ORDER field, was causing MW 1.17wmf1 to barf (array-for-ORDER-BY is not in 1.17wmf1)
Modified paths:
  • /trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php
——@@ -187,7 +187,7 @@
188188 __METHOD__,
189189 array(
190190 'LIMIT' => count( $wgArticleFeedbackRatings ),
191 - 'ORDER BY' => array( 'aa_revision DESC' ),
 191+ 'ORDER BY' => 'aa_revision DESC',
192192 ),
193193 array(
194194 'article_feedback_ratings' => array( 'LEFT JOIN', array( 'aar_id=aa_rating_id' ) )

Status & tagging log