r85999 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r85998
|
r85999
|
r86000
>
Date:
22:58, 13 April 2011
Author:
brion
Status:
ok
Tags:
Comment:
Use type hinting on CentralAuthUser::getInstance()'s user parameter. Makes it a little easier to track down things that pass bogus data in, such as the bad code in
r82120
(reverted in
r85997
).
Modified paths:
/trunk/extensions/CentralAuth/CentralAuthUser.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/CentralAuth/CentralAuthUser.php
—
—
@@ -54,7 +54,7 @@
55
55
* cache it in the User object.
56
56
* @param User $user
57
57
*/
58
- static function getInstance( $user ) {
58
+ static function getInstance( User $user ) {
59
59
if ( !isset( $user->centralAuthObj ) ) {
60
60
$user->centralAuthObj = new self( $user->getName() );
61
61
}
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r82120
Add a link to Special:CentralAuth/username on the Special:Contributions tool ...
raymond
17:59, 14 February 2011
r85997
Revert
r82120
: untested code causes fatal error on Special:Contributions when...
brion
22:57, 13 April 2011
Status & tagging log
00:59, 21 June 2011
Aaron Schulz
(
talk
|
contribs
)
changed the
status
of r85999
[
removed:
new
added:
ok]