r85958 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85957‎ | r85958 | r85959 >
Date:16:56, 13 April 2011
Author:neilk
Status:ok
Tags:
Comment:
titles on thanks page
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)
  • /trunk/extensions/UploadWizard/resources/uploadWizard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/uploadWizard.css
@@ -353,7 +353,7 @@
354354
355355 .mwe-upwiz-thumbnail {
356356 padding: 0.5em;
357 - width: 120px;
 357+ width: auto;
358358 }
359359
360360 .mwe-upwiz-thumbnail-side {
Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -1196,20 +1196,25 @@
11971197 var $thanksDiv = $j( '<div></div>' ).attr( 'id', id ).addClass( "mwe-upwiz-thanks ui-helper-clearfix" );
11981198 _this.thanksDiv = $thanksDiv;
11991199
1200 - var $thumbnailDiv = $j( '<div class="mwe-upwiz-thumbnail mwe-upwiz-thumbnail-side"></div>' );
1201 - $thanksDiv.append( $thumbnailDiv );
 1200+
 1201+ var $thumbnailDiv = $j( '<div></div>' ).addClass( 'mwe-upwiz-thumbnail' );
 1202+ var $thumbnailCaption = $j( '<div></div>' )
 1203+ .css( { 'text-align': 'center', 'font-size': 'small' } )
 1204+ .html( $j( '<a/>' ).html( upload.title.getMainText() ) );
 1205+ var $thumbnailWrapDiv = $j( '<div></div>' ).addClass( 'mwe-upwiz-thumbnail-side' );
 1206+ $thumbnailWrapDiv.append( $thumbnailDiv, $thumbnailCaption );
12021207 upload.setThumbnail( $thumbnailDiv );
1203 - //upload.setThumbnail( '#' + id + ' .mwe-upwiz-thumbnail' );
12041208
1205 - // Set the thumbnail link so that it points to the image description page
1206 - $thumbnailDiv.find( 'a' ).attr( {
 1209+ // Set the thumbnail links so that they point to the image description page
 1210+ $thumbnailWrapDiv.find( 'a' ).attr( {
12071211 'href': upload.imageinfo.descriptionurl,
12081212 'target' : '_new'
12091213 } );
 1214+ $thanksDiv.append( $thumbnailWrapDiv );
12101215
12111216 var thumbTitle = String(upload.title);
12121217 var thumbWikiText = "[[" + thumbTitle.replace('_', ' ') + "|thumb|" + gM( 'mwe-upwiz-thanks-caption' ) + "]]";
1213 -
 1218+
12141219 $thanksDiv.append(
12151220 $j( '<div class="mwe-upwiz-data"></div>' )
12161221 .append(

Status & tagging log