r85952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85951‎ | r85952 | r85953 >
Date:14:32, 13 April 2011
Author:siebrand
Status:ok
Tags:
Comment:
Update message related documentation.
Modified paths:
  • /trunk/extensions/SecurePoll/SecurePoll.i18n.php (modified) (history)
  • /trunk/extensions/SecurePoll/includes/pages/EntryPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SecurePoll/SecurePoll.i18n.php
@@ -231,8 +231,13 @@
232232 'securepoll-header-title' => '{{Identical|Name}}',
233233 'securepoll-header-start-date' => '{{Identical|Start date}}',
234234 'securepoll-header-end-date' => '{{Identical|End date}}',
235 - 'securepoll-subpage-vote' => '{{Identical|Vote}}',
236 - 'securepoll-subpage-translate' => '{{Identical|Translate}}',
 235+ 'securepoll-subpage-vote' => '{{Identical|Vote}}
 236+Link text to a sub page in the SecurePoll extension where users can vote.',
 237+ 'securepoll-subpage-translate' => '{{Identical|Translate}}
 238+Link text to a sub page in the SecurePoll extension where users can translate poll related texts.',
 239+ 'securepoll-subpage-list' => 'Link text to a sub page in the SecurePoll extension where users can list poll information.',
 240+ 'securepoll-subpage-dump' => 'Link text to a sub page in the SecurePoll extension where users can dump results.',
 241+ 'securepoll-subpage-tally' => 'Link text to a sub page in the SecurePoll extension where users can tally.',
237242 );
238243
239244 /** Afrikaans (Afrikaans)
Index: trunk/extensions/SecurePoll/includes/pages/EntryPage.php
@@ -12,7 +12,7 @@
1313 global $wgOut;
1414 $pager = new SecurePoll_ElectionPager( $this );
1515 $wgOut->addWikiMsg( 'securepoll-entry-text' );
16 - $wgOut->addHTML(
 16+ $wgOut->addHTML(
1717 $pager->getBody() .
1818 $pager->getNavigationBar()
1919 );
@@ -76,10 +76,10 @@
7777
7878 function isFieldSortable( $field ) {
7979 return in_array( $field, array(
80 - 'el_title', 'el_start_date', 'el_end_date'
 80+ 'el_title', 'el_start_date', 'el_end_date'
8181 ) );
8282 }
83 -
 83+
8484 /**
8585 * Add classes based on whether the poll is open or closed
8686 * @param $row database object
@@ -104,7 +104,7 @@
105105 return htmlspecialchars( $value );
106106 }
107107 }
108 -
 108+
109109 function formatRow( $row ) {
110110 global $wgUser;
111111 $id = $row->el_entity;
@@ -120,11 +120,16 @@
121121 function getLinks() {
122122 global $wgUser;
123123 $id = $this->mCurrentRow->el_entity;
124 -
 124+
125125 $s = '';
126126 $sep = wfMsg( 'pipe-separator' );
127127 $skin = $wgUser->getSkin();
128128 foreach ( $this->subpages as $subpage => $props ) {
 129+ // Message keys used here:
 130+ // securepoll-subpage-vote, securepoll-subpage-translate,
 131+ // securepoll-subpage-list, securepoll-subpage-dump,
 132+ // securepoll-subpage-tally
 133+
129134 $linkText = wfMsgExt( "securepoll-subpage-$subpage", 'parseinline' );
130135 if ( $s !== '' ) {
131136 $s .= $sep;
@@ -135,7 +140,7 @@
136141 $title = $this->entryPage->parent->getTitle( "$subpage/$id" );
137142 $s .= $skin->makeKnownLinkObj( $title, $linkText );
138143 } else {
139 - $s .= "<span class=\"securepoll-link-disabled\">" .
 144+ $s .= "<span class=\"securepoll-link-disabled\">" .
140145 $linkText . "</span>";
141146 }
142147 }
@@ -152,7 +157,7 @@
153158 if ( $field == 'links' ) {
154159 $names[$field] = '';
155160 } else {
156 - $msgName = 'securepoll-header-' .
 161+ $msgName = 'securepoll-header-' .
157162 strtr( $field, array( 'el_' => '', '_' => '-' ) );
158163 $names[$field] = wfMsg( $msgName );
159164 }
@@ -164,4 +169,4 @@
165170 return $this->entryPage->getTitle();
166171 }
167172 }
168 -
 173+

Status & tagging log