r85920 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85919‎ | r85920 | r85921 >
Date:20:56, 12 April 2011
Author:platonides
Status:ok
Tags:
Comment:
$wgDBprefix shall be converted to uppercase per r85786
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -179,7 +179,8 @@
180180 function __construct( $server = false, $user = false, $password = false, $dbName = false,
181181 $flags = 0, $tablePrefix = 'get from global' )
182182 {
183 - $tablePrefix = $tablePrefix == 'get from global' ? $tablePrefix : strtoupper( $tablePrefix );
 183+ global $wgDBprefix;
 184+ $tablePrefix = $tablePrefix == 'get from global' ? strtoupper( $wgDBprefix ) : strtoupper( $tablePrefix );
184185 parent::__construct( $server, $user, $password, $dbName, $flags, $tablePrefix );
185186 wfRunHooks( 'DatabaseOraclePostInit', array( $this ) );
186187 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85786* fix as per brion's comment on r85669freakolowsky13:50, 11 April 2011

Status & tagging log