r85912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85911‎ | r85912 | r85913 >
Date:20:02, 12 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Removed unneeded ORDER BY, which would degrade performance. See r85483
Modified paths:
  • /trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php
@@ -186,7 +186,7 @@
187187 __METHOD__,
188188 array(
189189 'LIMIT' => count( $wgArticleFeedbackRatings ),
190 - 'ORDER BY' => array( 'aa_revision DESC', 'aa_rating_id' ),
 190+ 'ORDER BY' => array( 'aa_revision DESC' ),
191191 ),
192192 array(
193193 'article_feedback_ratings' => array( 'LEFT JOIN', array( 'aar_id=aa_rating_id' ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85483Split expertise query into it's own method, since it's logged per revision no...tparscal22:59, 5 April 2011

Status & tagging log