r85883 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85882‎ | r85883 | r85884 >
Date:15:57, 12 April 2011
Author:yaron
Status:deferred
Tags:
Comment:
Changed first argument to startExternalParse() - attempted fix for call-by-reference of that param in MW < 1.18
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -350,7 +350,8 @@
351351 // remove the '<nowiki>' tags, leaving us with what we need.
352352 $form_def = "__NOEDITSECTION__" . strtr( $form_def, array( '{{{' => '<nowiki>{{{', '}}}' => '}}}</nowiki>' ) );
353353 if ( empty( $wgParser->mOptions ) ) {
354 - $wgParser->startExternalParse( $this->mPageTitle, ParserOptions::newFromUser($wgUser), Parser::OT_HTML, true );
 354+ $title = $this->mPageTitle;
 355+ $wgParser->startExternalParse( $title, ParserOptions::newFromUser($wgUser), Parser::OT_HTML, true );
355356 }
356357
357358 // Get the form definition from the cache, if we're using caching and it's